all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Matthias Heiserer <m.heiserer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH pve-docs 3/3] fix #3967: add ZFS dRAID documentation
Date: Thu, 2 Jun 2022 14:47:27 +0200	[thread overview]
Message-ID: <5bfa2e91-5512-1923-f6f0-c372a66ddaa2@proxmox.com> (raw)
In-Reply-To: <20220602112234.1868726-4-s.hrdlicka@proxmox.com>

I found a few typos :)
8<---
> +ZFS dRAID
> +~~~~~~~~~
> +
> +In a ZFS dRAID (declustered RAID) the hot spare drive(s) participate in the RAID.
> +Their spare capacity is reservered and used for rebuilding when one drive fails.
typo: reservered -> reserved
> +This provides depending on the configuration faster rebuilding compaired to a
Sounds a bit off to me. Maybe something like "Depending on the 
configuration, this provides..." would be better?
> +RAIDZ in case of drive failure. More information can be found in the official
> +openZFS documenation. footnote:[OpenZFS dRAID
typo: documenation -> documentation
> +https://openzfs.github.io/openzfs-docs/Basic%20Concepts/dRAID%20Howto.html]
> +
> +NOTE: dRAID is intended for more then 10-15 disks in a dRAID. A RAIDZ
> +setup should be better for a lower amount of disks in most use cases.
> +
> + * `dRAID1` or `dRAID`: requires at least 2 disks, one can fail before data is
> +lost
> + * `dRAID2`: requires at least 3 disks, two can fail before data is lost
> + * `dRAID3`: requires at least 4 disks, three can fail before data is lost
> +
> +
> +Additonal information can be found on manual page:
typo: Additional
> +
> +----
> +# man zpoolconcepts
> +----
> +
> +spares and data
I think we consistently start headers with a capital letter, so "spares" 
should be "Spares"
> +^^^^^^^^^^^^^^^
> +The number of `spares` tells the system how many disks it should keep ready in
> +case of of a disk failure. The default value is 0 `spares`. Without spares
typo: of of -> of
> +rebuilding won't get any speed benefits.
> +
> +The number of `data` devices specifies the size of a parity group. The default
> +is 8 if the number of `disks - parity - spares >= 8`. A higher number of `data`
> +and parity drives increases the allocation size (e.g. for 4k sectors with
> +default `data`=6 minimum allocation size is 24k) which can affect compression.
> +
> +
>   Bootloader
>   ~~~~~~~~~~
>   





  reply	other threads:[~2022-06-02 12:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-02 11:22 [pve-devel] [PATCH SERIES storage/manager/docs 0/3] add ZFS dRAID creation Stefan Hrdlicka
2022-06-02 11:22 ` [pve-devel] [PATCH pve-storage 1/3] fix #3967: enable ZFS dRAID creation via API Stefan Hrdlicka
2022-06-03 12:20   ` Dominik Csapak
2022-06-03 12:31   ` Dominik Csapak
2022-06-03 12:45     ` Dominik Csapak
2022-06-02 11:22 ` [pve-devel] [PATCH pve-manager 2/3] fix #3967: enable ZFS dRAID creation in WebGUI Stefan Hrdlicka
2022-06-03 12:24   ` Dominik Csapak
2022-06-07 14:41     ` Stefan Hrdlicka
2022-06-02 11:22 ` [pve-devel] [PATCH pve-docs 3/3] fix #3967: add ZFS dRAID documentation Stefan Hrdlicka
2022-06-02 12:47   ` Matthias Heiserer [this message]
2022-06-03 14:12     ` Thomas Lamprecht
2022-06-03 12:34   ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bfa2e91-5512-1923-f6f0-c372a66ddaa2@proxmox.com \
    --to=m.heiserer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal