From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] partially-applied: [PATCH widget-toolkit v7 0/4] fix #3893: make bridge vids configurable
Date: Mon, 18 Nov 2024 10:23:51 +0100 [thread overview]
Message-ID: <5a17fc33-044e-455f-bffa-131ebc2fa907@proxmox.com> (raw)
In-Reply-To: <4e9520fa-c0ac-45e4-bcff-62b4b46198f7@proxmox.com>
On 2024-11-16 16:41, Thomas Lamprecht wrote:
> Am 15.11.24 um 17:57 schrieb Aaron Lauterer:
>
>
> applied the widget toolkit with a few follow-ups to reduce code size and
> (try to) improve UX, maybe check them out to ensure nothing is off, thanks!
The UI changes, especially on the checks, seem to work as expected. Thanks!
>
> The manager I also applied and adapted to my wtk changes, but FWICT you seem
> missing the backend validation for VIDs? So please add something similar to
> the UI checks there, if I did not overlook the checks happening in some other
> part of the call chain that is.
Those were all part of the earlier version and are already applied.
Mainly in the register_format and accompanying validation function in
pve-common.
https://git.proxmox.com/?p=pve-common.git;a=blobdiff;f=src/PVE/JSONSchema.pm;h=7c63af1c3f203944fb7e33fe3e1a5273c6f0361c;hp=ce390927b41894f3b681ec04beb73da571dae288;hb=0219596da20533e88c6638c593c66c302ad1218e;hpb=a8b8920d54595e2213292276e3cf77c0181fd894
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-18 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 16:57 [pve-devel] " Aaron Lauterer
2024-11-15 16:57 ` [pve-devel] [PATCH widget-toolkit v7 1/4] fix #3892: network: add bridge vids field for bridge_vids Aaron Lauterer
2024-11-15 16:57 ` [pve-devel] [PATCH widget-toolkit v7 2/4] network: make bridge vids label wider to avoid line break Aaron Lauterer
2024-11-15 16:57 ` [pve-devel] [PATCH manager v7 3/4] fix #3893: api: network: add bridge_vids parameter Aaron Lauterer
2024-11-15 16:57 ` [pve-devel] [PATCH manager v7 4/4] fix #3893: ui: network: enable bridge_vids field Aaron Lauterer
2024-11-16 15:41 ` [pve-devel] partially-applied: [PATCH widget-toolkit v7 0/4] fix #3893: make bridge vids configurable Thomas Lamprecht
2024-11-18 9:23 ` Aaron Lauterer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a17fc33-044e-455f-bffa-131ebc2fa907@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.