From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] datastore: remove unsafe from function
Date: Thu, 4 Jul 2024 11:59:22 +0200 [thread overview]
Message-ID: <5a00a218-653a-4988-8c64-9a66432be5cb@proxmox.com> (raw)
In-Reply-To: <20240703145857.456017-1-g.goller@proxmox.com>
On 7/3/24 16:58, Gabriel Goller wrote:
> `list_snapshots_blocking` doesn't need to be unsafe.
I think that this is intentionally marked as `unsafe` to make sure the
caller really does look at the possible consequences of calling this
method. As documented, "This must not run in a main worker thread as it
potentially does tons of I/O."
So rather than dropping the `unsafe`, maybe clarify that this is the
reason for it being declared as unsafe in the comment.
But I guess Wolfgang can comment more on this.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-07-04 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 14:58 Gabriel Goller
2024-07-04 9:59 ` Christian Ebner [this message]
2024-07-04 11:05 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a00a218-653a-4988-8c64-9a66432be5cb@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.