From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] api2: network: anybridge: re-add regular bridges
Date: Wed, 27 Apr 2022 13:56:21 +0200 [thread overview]
Message-ID: <59b33eac-7203-3a9c-4517-b3c0f13d5f29@proxmox.com> (raw)
In-Reply-To: <20220427113600.166803-1-f.gruenbichler@proxmox.com>
On 27.04.22 13:36, Fabian Grünbichler wrote:
> commit 052fbb2a4d1bdeb490b2e3b67cd7555e460ebe93 introduced permission
> checks here that caused all regular bridges to be removed from the
> returned list as soon as the SDN package is installed, unless the user
> is root@pam or there exists a VNET with the same ID.
>
> this is arguably a breaking change, so limit the priv check to actually
> defined VNETs for the time being, and add ALL regular bridges
> uncondtionally like before.
>
> get_local_vnets already filters by the same prvs, so we need to get the
> full config to find out which IDs are VNETs and which are not.
>
> once/iff we introduce ACL paths for *all* bridges in the future, we can
> limit accordingly here.
>
> CC: Alexandre Derumier <aderumier@odiso.com>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> PVE/API2/Network.pm | 3 +++
> 1 file changed, 3 insertions(+)
>
>
applied, thanks!
next prev parent reply other threads:[~2022-04-27 11:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 11:36 [pve-devel] " Fabian Grünbichler
2022-04-27 11:56 ` Thomas Lamprecht [this message]
2022-04-27 12:32 ` DERUMIER, Alexandre
2022-04-27 12:45 ` Fabian Grünbichler
2022-04-27 13:04 ` DERUMIER, Alexandre
2022-04-27 13:15 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59b33eac-7203-3a9c-4517-b3c0f13d5f29@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal