From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH font-logos/manager v2 0/5] fix #2435: lxc: show distro and privileged status in summary
Date: Fri, 20 Oct 2023 15:33:19 +0200 [thread overview]
Message-ID: <58d30e37-be45-42bf-82f6-1e9e57a53bb1@proxmox.com> (raw)
In-Reply-To: <20230705111257.759836-1-c.heiss@proxmox.com>
the series looks mostly fine to me, i wrote two small
comments in the relevant patches, but both
are not super important to fix IMO
aside from that consider this series
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
next prev parent reply other threads:[~2023-10-20 13:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 11:12 Christoph Heiss
2023-07-05 11:12 ` [pve-devel] [PATCH font-logos v2 1/5] d/install: fix typo in css install path Christoph Heiss
2023-07-05 11:12 ` [pve-devel] [PATCH font-logos v2 2/5] css: fix missing `@` for font-face rule Christoph Heiss
2023-07-05 11:12 ` [pve-devel] [PATCH manager v2 3/5] pveproxy, ui, d/control: add font-logos Christoph Heiss
2023-07-05 11:12 ` [pve-devel] [PATCH manager v2 4/5] ui: GuestStatusView: show privileged status as new row Christoph Heiss
2023-10-20 13:27 ` Dominik Csapak
2023-07-05 11:12 ` [pve-devel] [PATCH manager v2 5/5] ui: GuestStatusView: show distro logo and name in summary header Christoph Heiss
2023-10-20 13:31 ` Dominik Csapak
2023-10-11 14:41 ` [pve-devel] [PATCH font-logos/manager v2 0/5] fix #2435: lxc: show distro and privileged status in summary Christoph Heiss
2023-10-20 13:33 ` Dominik Csapak [this message]
2023-10-23 15:32 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58d30e37-be45-42bf-82f6-1e9e57a53bb1@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal