From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Leo Nunner <l.nunner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 manager] fix #4481: fetch changelogs for any Proxmox repository
Date: Wed, 1 Feb 2023 12:38:28 +0100 [thread overview]
Message-ID: <58bff4b4-c4cf-3f0c-95fb-c580d0bde6dc@proxmox.com> (raw)
In-Reply-To: <20230130105953.126483-1-l.nunner@proxmox.com>
Am 30/01/2023 um 11:59 schrieb Leo Nunner:
> This patch fixes the issue that when the user supplied any non-standard
> repositories, the changelogs often wouldn't load. For example, providing
> both pve-no-subscription and pbs-no-subscription broke the changelog
> API, since the URL built for pbs-no-subscription was invalid.
>
> Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
> ---
> Changes from v1:
> - Directly pass $pkgfile to get_changelog_url
> - Only check enabled repositories
> - Compare the site of the package with the repository URL
>
> PVE/API2/APT.pm | 28 +++++++++++++++++++++-------
> 1 file changed, 21 insertions(+), 7 deletions(-)
>
>
applied, thanks!
with a few (mostly unrelated to this patch) cleanups in the module and a comment
for why passing "pve" to the Proxmox::RS::APT::Repositories::repositories is done
and that we actually check all configured repos not only PVE specific,
prev parent reply other threads:[~2023-02-01 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 10:59 [pve-devel] " Leo Nunner
2023-02-01 9:15 ` Thomas Lamprecht
2023-02-01 11:38 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58bff4b4-c4cf-3f0c-95fb-c580d0bde6dc@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.nunner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal