From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH qemu-server 3/3] fix #6007: template backup: use minimized configuration for handling the full vm start
Date: Fri, 24 Jan 2025 11:47:39 +0100 [thread overview]
Message-ID: <586b19c3-199e-4625-b771-b043bf1ccbac@proxmox.com> (raw)
In-Reply-To: <2effc6f4-7624-4f78-9480-b94df117fa66@proxmox.com>
Am 24.01.25 um 11:23 schrieb Fiona Ebner:
>> @@ -4017,7 +4018,7 @@ sub config_to_command {
>> push @$cmd, @$aa;
>> }
>>
>> - return wantarray ? ($cmd, $vollist, $spice_port, $pci_devices) : $cmd;
>> + return wantarray ? ($cmd, $vollist, $spice_port, $pci_devices, $conf) : $cmd;
>> }
>>
>
> Hmm, thinking about it again, to reduce regression potential, we could
> also just return the temporary config if it was actually required and
> have the caller only assign it when really present.
Although I suppose it doesn't really give us anything after all. I was
worried a bit about things like potential auto-vivification, but since
we already use the original $conf hash ref throughout the function
(except in the template case), such things would already affect the caller.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-01-24 10:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 10:08 [pve-devel] [PATCH-SERIES qemu-server 0/3] fix #6007: fix PBS template backup for certain configurations Fiona Ebner
2025-01-24 10:08 ` [pve-devel] [PATCH qemu-server 1/3] backup: also restore VM power state for early failures Fiona Ebner
2025-01-24 10:08 ` [pve-devel] [PATCH qemu-server 2/3] config: introduce a flag to prevent writing the configuration Fiona Ebner
2025-01-24 10:18 ` Thomas Lamprecht
2025-01-24 10:25 ` Fiona Ebner
2025-01-24 10:08 ` [pve-devel] [PATCH qemu-server 3/3] fix #6007: template backup: use minimized configuration for handling the full vm start Fiona Ebner
2025-01-24 10:23 ` Fiona Ebner
2025-01-24 10:47 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=586b19c3-199e-4625-b771-b043bf1ccbac@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.