From: Fiona Ebner <f.ebner@proxmox.com>
To: Lukas Sichert <l.sichert@proxmox.com>, pve-devel@lists.proxmox.com
Subject: superseded: [PATCH-SERIES qemu-server v3 00/18] fix #7066: api: allow live snapshot (remove) of qcow2 TPM drive with snapshot-as-volume-chain
Date: Fri, 24 Apr 2026 14:11:24 +0200 [thread overview]
Message-ID: <585d77ce-5bc6-43a5-9644-8b1a7b1f21ec@proxmox.com> (raw)
In-Reply-To: <DI1D9E6C3KM0.5TSEG89WLZ5V@proxmox.com>
Am 24.04.26 um 1:58 PM schrieb Lukas Sichert:
> I went through the code and the changes look good overall, just
> two small nits:
>
> The git history is somewhat confusing. Changes introduced in one
> commit are modified again in later commits. This would be
> completely fine if it ensured that the codebase remains in a
> consistent state after each commit, but as already discussed in
> [1], this is not always the case. That said, the series works
> correctly once applied in full.
>
> Also, in my opinion, 'qsd_qmp_peer' would be a better name than
> 'qsd_peer' to make it explicit that this refers to a QMP peer
> and to keep naming consistent with 'vm_qmp_peer'.
>
>
> [1] lore.proxmox.com/pve-devel/DI0L56K45KJK.1G3MBGPZI2KJV@proxmox.com/T/#m7e7ffe8240f4092755e27c6072e0e27ffcdd96b5
Sorry, was a bit too eager with sending v4. I added the rename as an
optional follow-up there too now.
superseded-by: <20260424114722.107671-1-f.ebner@proxmox.com>
prev parent reply other threads:[~2026-04-24 12:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 9:35 [PATCH-SERIES qemu-server v3 00/18] fix #7066: api: allow live snapshot (remove) of qcow2 TPM drive with snapshot-as-volume-chain Fiona Ebner
2026-04-23 9:35 ` [PATCH qemu-server v3 01/18] block job: fix variable name in documentation Fiona Ebner
2026-04-23 9:35 ` [PATCH qemu-server v3 02/18] qmp client: add default timeouts for more block commands Fiona Ebner
2026-04-23 9:35 ` [PATCH qemu-server v3 03/18] drive: introduce drive_uses_qsd_fuse() helper Fiona Ebner
2026-04-23 9:35 ` [PATCH qemu-server v3 04/18] monitor: add vm_qmp_peer() helper Fiona Ebner
2026-04-23 9:35 ` [PATCH qemu-server v3 05/18] monitor: add qsd_peer() helper Fiona Ebner
2026-04-23 9:36 ` [PATCH qemu-server v3 06/18] blockdev: rename variable in get_node_name_below_throttle() for readability Fiona Ebner
2026-04-23 9:36 ` [PATCH qemu-server v3 07/18] blockdev: switch get_node_name_below_throttle() to use QMP peer Fiona Ebner
2026-04-23 9:36 ` [PATCH qemu-server v3 08/18] blockdev: switch detach() " Fiona Ebner
2026-04-23 9:36 ` [PATCH qemu-server v3 09/18] blockdev: switch blockdev_replace() " Fiona Ebner
2026-04-23 9:36 ` [PATCH qemu-server v3 10/18] blockdev: switch blockdev_external_snapshot() " Fiona Ebner
2026-04-23 9:36 ` [PATCH qemu-server v3 11/18] block job: switch qemu_handle_concluded_blockjob() " Fiona Ebner
2026-04-24 9:51 ` Lukas Sichert
2026-04-24 11:36 ` Fiona Ebner
2026-04-23 9:36 ` [PATCH qemu-server v3 12/18] block job: switch qemu_blockjobs_cancel() " Fiona Ebner
2026-04-23 9:36 ` [PATCH qemu-server v3 13/18] block job: switch qemu_drive_mirror_monitor() " Fiona Ebner
2026-04-23 9:36 ` [PATCH qemu-server v3 14/18] blockdev: switch blockdev_delete() " Fiona Ebner
2026-04-23 9:36 ` [PATCH qemu-server v3 15/18] blockdev: switch blockdev_stream() " Fiona Ebner
2026-04-23 9:36 ` [PATCH qemu-server v3 16/18] blockdev: switch blockdev_commit() " Fiona Ebner
2026-04-24 11:49 ` Lukas Sichert
2026-04-24 11:56 ` Fiona Ebner
2026-04-24 12:09 ` Lukas Sichert
2026-04-23 9:36 ` [PATCH qemu-server v3 17/18] snapshot: support live snapshot (remove) of qcow2 TPM drive on storage with snapshot-as-volume-chain Fiona Ebner
2026-04-23 9:36 ` [PATCH qemu-server v3 18/18] fix #7066: api: allow live snapshot (remove) of qcow2 TPM drive " Fiona Ebner
2026-04-23 13:57 ` [PATCH-SERIES qemu-server v3 00/18] " Lukas Sichert
2026-04-24 11:59 ` Lukas Sichert
2026-04-24 12:11 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=585d77ce-5bc6-43a5-9644-8b1a7b1f21ec@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=l.sichert@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.