superseded: [PATCH-SERIES qemu-server v3 00/18] fix #7066: api: allow live snapshot (remove) of qcow2 TPM drive with snapshot-as-volume-chain

Fiona Ebner
2026-04-24T12:19:31Z

Am 24.04.26 um 1:58 PM schrieb Lukas Sichert:
> I went through the code and the changes look good overall, just
> two small nits:
>
> The git history is somewhat confusing. Changes introduced in one
> commit are modified again in later commits. This would be
> completely fine if it ensured that the codebase remains in a
> consistent state after each commit, but as already discussed in
> [1], this is not always the case. That said, the series works
> correctly once applied in full.
>
> Also, in my opinion, 'qsd_qmp_peer' would be a better name than
> 'qsd_peer' to make it explicit that this refers to a QMP peer
> and to keep naming consistent with 'vm_qmp_peer'.
>
>
> [1] lore.proxmox.com/pve-devel/DI0L56K45KJK.1G3MBGPZI2KJV@proxmox.com/T/#m7e7ffe8240f4092755e27c6072e0e27ffcdd96b5

Sorry, was a bit too eager with sending v4. I added the rename as an
optional follow-up there too now.

superseded-by: <20260424114722.107671-1-f.ebner@proxmox.com>