Re: [pve-devel] [PATCH pve-manager 2/2] move /run/vzdump.lock to /run/lock/vzdump.lock

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 24.03.25 um 12:41 schrieb Jing Luo:
> On 2025-03-24 17:02, Thomas Lamprecht wrote:
>> The same holds for all patches of this series.
> 
> What's wrong with other patches in the series? No lock file path is 
> moved, b/c
> /var/run is a symlink to /run and /var/lock is a symlink to /run/lock, 
> unless
> we have to account for non-Debian systems where /var/run and /var/lock 
> are not
> symlinks?
> 

Yeah, that I noticed later too, but it would be indeed good to check if
this is a guarantee (i.e., by Debian policy) for all systems now, even
if they got created with a very ancient PVE/Debian version.

I only did a quick check, and found [0]:

> Packages must not include files or directories under /run, or under
> the older /var/run and /var/lock paths. The latter paths will normally
> be symlinks or other redirections to /run for backwards compatibility.

[0]: https://www.debian.org/doc/debian-policy/ch-opersys.html#run-and-run-lock

So does not seem like a hard guarantee that /var/lock is always a symlink
to /run/lock and that /var/run is always a symlink to /run, so if the
careful approach would be to switch to the new paths for our Trixie based
builds and add a check for the case where /var/lock and /var/run are not
symlinks in the future pve8to9 checker script and output a warning/error
in that case; that said I'm not sure if it's worth it, would be maybe good
to see since which Debian/PVE version the symlink exists to be able to
better judge that though.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel