From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: [pve-devel] applied: [PATCH proxmox-firewall] firewall: apply `nt_conntrack_allow_invalid` option to guest table
Date: Sun, 17 Nov 2024 15:34:19 +0100 [thread overview]
Message-ID: <581a9b64-9f66-41ff-8b74-3a3b1eb56fc9@proxmox.com> (raw)
In-Reply-To: <20241115153016.118024-1-h.laimer@proxmox.com>
Am 15.11.24 um 16:30 schrieb Hannes Laimer:
> So it behaves the same way the 'old' firewall did. Since currently
> ct state invalid are always dropped on the guest table, regardless
> of the option. The host behaviour is not changed as it would
> require `forward` to match the 'old' behaviour.
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> based on what @Stefan suggested in response to [1]. This matches what the
> old fw did with this option on vms.
>
> [1] https://lore.proxmox.com/pve-devel/918ffc4c-c371-4d43-8c2c-849e618273b6@proxmox.com/T/#t
>
> .../resources/proxmox-firewall.nft | 4 +++-
> proxmox-firewall/src/firewall.rs | 10 ++++++++
> .../integration_tests__firewall.snap | 23 +++++++++++++++++++
> 3 files changed, 36 insertions(+), 1 deletion(-)
>
>
applied, thanks!
I had to resolve some merge conflicts from context changes due to applying
Stefan's proxmox-firewall patches upfront.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-17 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 15:30 [pve-devel] " Hannes Laimer
2024-11-17 14:34 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=581a9b64-9f66-41ff-8b74-3a3b1eb56fc9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal