From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Filip Schauer <f.schauer@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 manager] ui: acme: switch cluster view items over to those from widget-toolkit
Date: Tue, 12 Nov 2024 20:47:31 +0100 [thread overview]
Message-ID: <57f8a4f8-b972-4f89-a571-2340f2d48acd@proxmox.com> (raw)
In-Reply-To: <20240430111758.77240-1-f.schauer@proxmox.com>
Am 30.04.24 um 13:17 schrieb Filip Schauer:
> The pmxACMEAccountView & pmxACMEPluginView in proxmox-widget-toolkit
> were copied from pve-manager in commits 5df894de and 658bfdff. This
> makes pveACMEAccountView & pveACMEPluginView redundant, hence remove
> them and use pmxACMEAccountView & pmxACMEPluginView instead.
>
> This leaves PVE.node.ACMEAccountView & pveACMEPluginEditor unused, so
> remove them too.
>
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
> ---
> Changes since v1:
> * Also switch over account view
> * Correct acmeUrl (/config/acme -> /cluster/acme)
> * Reference introduction of pmxACMEAccountView & pmxACMEPluginView in
> commit message
> * Remove ACMEPluginEdit.js from the Makefile
>
> www/manager6/Makefile | 1 -
> www/manager6/dc/ACMEClusterView.js | 204 +-------------------------
> www/manager6/dc/ACMEPluginEdit.js | 223 -----------------------------
> www/manager6/node/ACME.js | 66 ---------
> 4 files changed, 4 insertions(+), 490 deletions(-)
> delete mode 100644 www/manager6/dc/ACMEPluginEdit.js
>
>
Look OK in general but needs a rebase due to a typo fix in the deleted file and
I get an exception when navigating to the Datacenter -> ACME panel, so maybe
something else changed that needs adaption here.
20:45:51.345 Uncaught neither 'url' nor both, submitUrl and loadUrl specified proxmoxlib.js:12473:6
initComponent https://d8.work.tlmp.it:8006/proxmoxlib.js?ver=v4.3.0-t1731358651:12473
callParent ExtJS
initComponent https://d8.work.tlmp.it:8006/proxmoxlib.js?ver=v4.3.0-t1731358651:14055
ExtJS 2
constructor https://d8.work.tlmp.it:8006/proxmoxlib.js?ver=v4.3.0-t1731358651:12284
ExtJS 17
activateCard https://d8.work.tlmp.it:8006/pve2/js/pvemanagerlib.js?ver=8.2.8:13600
selectionchange https://d8.work.tlmp.it:8006/pve2/js/pvemanagerlib.js?ver=8.2.8:13544
ExtJS 39
initComponent https://d8.work.tlmp.it:8006/pve2/js/pvemanagerlib.js?ver=8.2.8:60157
callParent ExtJS
initComponent https://d8.work.tlmp.it:8006/pve2/js/pvemanagerlib.js?ver=8.2.8:60615
ExtJS 4
<anonym> https://d8.work.tlmp.it:8006/#v1:0:18:4:10:=contentIso::30:8::=sdnmappings:41
ExtJS 15
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-12 19:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 11:17 Filip Schauer
2024-11-12 19:47 ` Thomas Lamprecht [this message]
2024-11-13 13:29 ` Filip Schauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57f8a4f8-b972-4f89-a571-2340f2d48acd@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.