Re: [pve-devel] [RFC storage 4/4] plugin: parse_name_dir: drop deprecation warning

[Fiona Ebner <f.ebner@proxmox.com>]

Am 31.07.25 um 1:15 PM schrieb Fabian Grünbichler:
> this gets printed very often if such a volume exists - e.g. adding such a
> volume to a config with `qm set` prints it 10 times..

Agreed with the change, that is too noisy.

> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> we could maybe just warn in the list_images code path? or add a check to
> pve8to9?

A warning pve8to9 would be good in any case. Not sure if we already want
to warn in list_images() this early if we're only gonna drop it in PVE
10? A warning during image allocation might be nice though.

>  src/PVE/Storage/Plugin.pm | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
> index db05e0e..2291d72 100644
> --- a/src/PVE/Storage/Plugin.pm
> +++ b/src/PVE/Storage/Plugin.pm
> @@ -718,7 +718,6 @@ sub parse_name_dir {
>      } elsif ($name =~ m!^snap-.*\.qcow2$!) {
>          die "'$name' is a snapshot filename, not a volume!\n";
>      } elsif ($name =~ m!^((base-)?[^/\s]+\.(raw|qcow2|vmdk|subvol))$!) {
> -        warn "this volume name `$name` is deprecated, please use (base-/vm-/subvol-)-NNN- as prefix\n";
>          return ($1, $3, $2); # (name ,format, isBase)
>      }
>  



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel