From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pbs-devel] applied: Re: [PATCH proxmox-backup] datastore: chown base dir on creation
Date: Thu, 9 Jul 2020 21:32:21 +0200 [thread overview]
Message-ID: <57c192bf-0d90-8393-04c2-ac43f242f901@proxmox.com> (raw)
In-Reply-To: <20200709161528.22249-1-s.ivanov@proxmox.com>
On 09.07.20 18:15, Stoiko Ivanov wrote:
> When creating a new datastore the basedir is only owned by the backup
> user if it did not exist beforehand (create_path chowns only if it
> creates the directory), and returns false if it did not create the
> directory).
>
> This improves the experience when adding a new datastore on a fresh
> disk or existing directory (not owned by backup) - backups/pulls can
> be run instead of terminating with EPERM.
>
> Tested on my local testinstall with a new disk, and a existing directory:
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> src/backup/chunk_store.rs | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2020-07-09 19:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 16:15 [pbs-devel] " Stoiko Ivanov
2020-07-09 19:32 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57c192bf-0d90-8393-04c2-ac43f242f901@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.