From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Timothy Nicholson <t.nicholson@proxmox.com>
Subject: [pve-devel] applied: [PATCH widget-toolkit v3] fix #5836: ui: translate systemd states in ServiceView
Date: Mon, 11 Nov 2024 21:38:04 +0100 [thread overview]
Message-ID: <57791de5-505f-460c-9fc7-9a455913cca7@proxmox.com> (raw)
In-Reply-To: <20241111131715.173179-1-t.nicholson@proxmox.com>
Am 11.11.24 um 14:17 schrieb Timothy Nicholson:
> Signed-off-by: Timothy Nicholson <t.nicholson@proxmox.com>
> ---
> changes since v2 [0]:
> - use object instead of switch-case statement for systemd states
> - use different terms (starting/stopping) for start/stop states
> [0]: https://lore.proxmox.com/pve-devel/20241111103705.76679-1-t.nicholson@proxmox.com/
>
> src/Utils.js | 12 ++++++++++++
> src/node/ServiceView.js | 14 ++++++--------
> 2 files changed, 18 insertions(+), 8 deletions(-)
>
>
applied, thanks!
Albeit I could imagine that we might someday need different maps for the
state and unit-state ones, but for now it should work out FWICT.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-11 20:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 13:17 [pve-devel] " Timothy Nicholson
2024-11-11 20:38 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57791de5-505f-460c-9fc7-9a455913cca7@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.nicholson@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.