From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH common v4 3/7] inotify: interfaces: make sure bridge_vids use space as separator
Date: Tue, 10 Sep 2024 11:37:26 +0200 [thread overview]
Message-ID: <5742e006-6d8d-4a54-9b12-69b614461b64@proxmox.com> (raw)
In-Reply-To: <20240729115540.191594-4-a.lauterer@proxmox.com>
Am 29.07.24 um 13:55 schrieb Aaron Lauterer:
> Because the API accepts multiple possible list separators we need to
> make sure that we write the bridge_vids with space as separator, no
> matter which separator was used when passing it to the API.
>
Nit: The reason why it's necessary to write out with space as the
separator is missing. Who gets confused otherwise ;)?
Should we do the conversion earlier, i.e. in the API endpoint when
writing the interface parameters? Like that we don't end up carrying the
invalid value around.
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> Tested-By: Stefan Hanreich <s.hanreich@proxmox.com>
> Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>
Still:
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-09-10 9:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 11:55 [pve-devel] [PATCH common, widget-toolkit, manager v4 0/7] fix #3893: make bridge vids configurable Aaron Lauterer
2024-07-29 11:55 ` [pve-devel] [PATCH common v4 1/7] tools: add check_list_empty function Aaron Lauterer
2024-09-09 14:02 ` Fiona Ebner
2024-09-10 6:56 ` Aaron Lauterer
2024-07-29 11:55 ` [pve-devel] [PATCH common v4 2/7] fix #3893: network: add vlan id and range parameter definitions Aaron Lauterer
2024-09-10 9:21 ` Fiona Ebner
2024-07-29 11:55 ` [pve-devel] [PATCH common v4 3/7] inotify: interfaces: make sure bridge_vids use space as separator Aaron Lauterer
2024-09-10 9:37 ` Fiona Ebner [this message]
2024-07-29 11:55 ` [pve-devel] [PATCH widget-toolkit v4 4/7] fix #3892: Network: add bridge vids field for bridge_vids Aaron Lauterer
2024-07-29 11:55 ` [pve-devel] [PATCH widget-toolkit v4 5/7] Network: add explanation for bridge vids field Aaron Lauterer
2024-07-29 11:55 ` [pve-devel] [PATCH manager v4 6/7] fix #3893: api: network: add bridge_vids parameter Aaron Lauterer
2024-07-29 11:55 ` [pve-devel] [PATCH manager v4 7/7] fix #3893: ui: network: enable bridge_vids field Aaron Lauterer
2024-10-02 13:13 ` [pve-devel] [PATCH common, widget-toolkit, manager v4 0/7] fix #3893: make bridge vids configurable Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5742e006-6d8d-4a54-9b12-69b614461b64@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.