From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH proxmox-backup 0/3] file-restore: set arc limits correctly
Date: Thu, 15 Jun 2023 18:11:22 +0200 [thread overview]
Message-ID: <568cd927-bbad-7680-51b5-475f2f19b55c@proxmox.com> (raw)
In-Reply-To: <20230615104257.3387232-1-s.ivanov@proxmox.com>
Am 15/06/2023 um 12:42 schrieb Stoiko Ivanov:
> The first two patches fix the setting of zfs_arc_min and zfs_arc_max via
> the kernel commandline - afaics they should not have been honored until
> now - verification was done in the debug-image by inspecting
> `grep '^c_' /proc/spl/kstat/zfs/arcstats`
>
> the first 2 patches can be squashed - it explicitly split them out for
> ease of reviewing
>
> the last patch is more as an rfc, because it puzzled my why a debug-log
> message was not printed when running with debug.
>
>
> Stoiko Ivanov (3):
> file-restore: add zfs. prefix to arc_min/max settings
> file-restore: set zfs_arc_min to current minimum of 32M
> file-restore: set loglevel considering PBS_QEMU_DEBUG
>
> proxmox-file-restore/src/main.rs | 7 ++++++-
> proxmox-file-restore/src/qemu_helper.rs | 2 +-
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
applied, thanks!
I made a follow-up to factor out the is-debug-mode logic in file-restore, not that
it gets out of sync when exactly it gets enabled (e.g., for some tools it's enough
if such a variable is set, even if empty, so if one would change one side but not
the other it could get confusing).
prev parent reply other threads:[~2023-06-15 16:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 10:42 [pve-devel] " Stoiko Ivanov
2023-06-15 10:42 ` [pve-devel] [PATCH proxmox-backup 1/3] file-restore: add zfs. prefix to arc_min/max settings Stoiko Ivanov
2023-06-15 10:42 ` [pve-devel] [PATCH proxmox-backup 2/3] file-restore: set zfs_arc_min to current minimum of 32M Stoiko Ivanov
2023-06-15 10:42 ` [pve-devel] [PATCH proxmox-backup 3/3] file-restore: set loglevel considering PBS_QEMU_DEBUG Stoiko Ivanov
2023-06-15 16:11 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568cd927-bbad-7680-51b5-475f2f19b55c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.