From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pve-devel] [PATCH network] frr: early exit on apply when frr is not installed
Date: Wed, 23 Jul 2025 18:28:39 +0200 [thread overview]
Message-ID: <56352b35-32af-4c16-ac7e-97db68049e80@proxmox.com> (raw)
In-Reply-To: <03272d0d-e472-4188-b8a0-4d408dbf89f3@proxmox.com>
Am 23.07.25 um 18:26 schrieb Stefan Hanreich:
>> + if (!-e $PVE::Network::SDN::Frr::FRR_CONFIG_FILE) {
>> + print "frr is not installed, not generating any frr configuration\n";
>> + return;
>> + }
>> +
> The old code checked for the existence of /etc/frr [1] - maybe we should
> keep it like that?
>
> [1]
> https://git.proxmox.com/?p=pve-network.git;a=blob;f=src/PVE/Network/SDN/Controllers/EvpnPlugin.pm;h=5b1a9aa73c8048bab21d9087d1ba4715f4d2425a;hb=8f4f5d2074989cf814d2f2312360239377c495f5#l612
Yeah, might become a "chicken and egg" problem otherwise.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-23 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 15:49 Gabriel Goller
2025-07-23 16:26 ` Stefan Hanreich
2025-07-23 16:28 ` Thomas Lamprecht [this message]
2025-07-23 16:46 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56352b35-32af-4c16-ac7e-97db68049e80@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.