From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: PVE development discussion <pve-devel@pve.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/1] ui: use ZFS components and functions from widget-toolkit
Date: Thu, 3 Sep 2020 18:32:40 +0200 [thread overview]
Message-ID: <55f1f70a-c676-98ba-c98f-7cb64876b605@proxmox.com> (raw)
In-Reply-To: <20200625115933.20108-5-d.csapak@proxmox.com>
On 25.06.20 13:59, Dominik Csapak wrote:
> render_zfs_health is now in widget-toolkit
> as well as the 'MultiDiskSelector' and the Detailwindow
>
> and drop the now unnecessary classes
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/Utils.js | 26 ----
> www/manager6/node/ZFS.js | 255 +--------------------------------------
> 2 files changed, 6 insertions(+), 275 deletions(-)
>
seems that Utils conflicts now, can you please check why (not that we added here
something which is missing in the wtk variant), rebase and do a d/control dependency
version bump along side? Thanks!
parent reply other threads:[~2020-09-03 16:33 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200625115933.20108-5-d.csapak@proxmox.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55f1f70a-c676-98ba-c98f-7cb64876b605@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@pve.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.