From: Fiona Ebner <f.ebner@proxmox.com>
To: Daniel Kral <d.kral@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH ha-manager 3/4] config, env: allow bulk updates with update_resources_config
Date: Mon, 19 Jan 2026 13:44:44 +0100 [thread overview]
Message-ID: <54ae18f9-3ac9-45a7-84f7-aeee2331d193@proxmox.com> (raw)
In-Reply-To: <DFSK7PT0JT0M.1VX6B2DVWE8ZF@proxmox.com>
Am 19.01.26 um 1:19 PM schrieb Daniel Kral:
> On Mon Jan 19, 2026 at 12:48 PM CET, Fiona Ebner wrote:
>> Nit: I feel like the $delete belongs inside the $changes for a clean
>> interface. So something like
>> $changes = {
>> $sid => {
>> param => $param,
>> delete => $delete,
>> }
>> }
>>
>> I know the single caller using bulk won't need it, but the current
>> interface does feel slightly off to me. What do you think?
>
> Sounds good, will do! Just for clarification: Is `param => $param` a
> single changed property or is $param the hash of changes?
I'd keep them together as a hash. Then we don't mix keys for single
properties and the 'delete' key (which is on a different level
semantically).
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2026-01-19 12:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 10:18 [pve-devel] [PATCH ha-manager 0/4] fix #7133 and improve group migration Daniel Kral
2025-12-15 10:18 ` [pve-devel] [PATCH ha-manager 1/4] fix #7133: manager: group migration: skip update for resources without group Daniel Kral
2025-12-15 10:18 ` [pve-devel] [PATCH ha-manager 2/4] manager: group migration: write only non-default failback values Daniel Kral
2025-12-15 10:18 ` [pve-devel] [PATCH ha-manager 3/4] config, env: allow bulk updates with update_resources_config Daniel Kral
2026-01-19 11:48 ` Fiona Ebner
2026-01-19 12:20 ` Daniel Kral
2026-01-19 12:44 ` Fiona Ebner [this message]
2025-12-15 10:18 ` [pve-devel] [PATCH ha-manager 4/4] manager: group migration: bulk update changes to resource config Daniel Kral
2026-01-19 11:49 ` [pve-devel] [PATCH ha-manager 0/4] fix #7133 and improve group migration Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ae18f9-3ac9-45a7-84f7-aeee2331d193@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.