Re: [pbs-devel] [PATCH proxmox-backup 3/3] fix #3939: ui: default realm setting in NodeOptionView

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 11.04.22 12:03, Matthias Heiserer wrote:
>>>
>>> diff --git a/www/config/NodeOptionView.js b/www/config/NodeOptionView.js
>>> index bb12513b..f3652a53 100644
>>> --- a/www/config/NodeOptionView.js
>>> +++ b/www/config/NodeOptionView.js
>>> @@ -53,8 +53,31 @@ Ext.define('PBS.NodeOptionView', {
>>>       },
>>>       ],
>>>   +    add_pmxRealmComboBox_row: function(name, text, opts) {
>>
>> I'd figure that camels and snakes don't mix well, at least in casing style 😉
>>
>> But in general: this is unnecessary, as currently used you can just add another
>> static entry in the `gridRows` array, and if the user of this whole component
>> needs to be able to config something (which they ain't with your approach, but
>> it feels like that was the aim?) a simple (c)bind can avoid such intermediate
>> creation helper.
> I don't think I can drop this function, because for each row entry the ObjectGrid searches for a function named `add_${rowdef.xtype}_row` and throws an error if none can be found. That's also the reason for the strange name.
> Maybe I misunderstand something?

Sorry, I meant adding it statically to the `rows` array.

An yeah forgot the "nice" details of ObjectGrid's gridRow, it really should be
cleaned up sometimes..