From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>,
pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-gui v3] backup-configuration: Add icons to tab buttons
Date: Thu, 7 Sep 2023 08:33:40 +0200 [thread overview]
Message-ID: <545eef87-afaa-4c8d-89f7-9bb0be0b0463@proxmox.com> (raw)
In-Reply-To: <20230906130907.2036832-1-m.sandoval@proxmox.com>
Am 06/09/2023 um 15:09 schrieb Maximiliano Sandoval:
> From a UX perspective flat buttons, i.e. buttons without a frame or
> background, are not obviously clickable without an icon.
>
> The choice of icons was taken from pve-manager's Utils.js module.
I amended the commit to mention the storageSchema map and change
Utils.js to PVE.Utils, as that's the module name relevant when
actually using it.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> Differences from v2:
> - Use folder icon as suggest in v2 of the patch
> - Improved commit message
>
> js/BackupConfiguration.js | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2023-09-07 6:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 13:09 [pmg-devel] " Maximiliano Sandoval
2023-09-07 6:33 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545eef87-afaa-4c8d-89f7-9bb0be0b0463@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.