From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Max Carrara <m.carrara@proxmox.com>
Subject: [pve-devel] applied: [PATCH v1 pve-common 0/3] Section Config: Documentation & Code Cleanup
Date: Wed, 24 Jul 2024 13:34:59 +0200 [thread overview]
Message-ID: <54106e85-064f-42db-bc5e-0f7e43495de8@proxmox.com> (raw)
In-Reply-To: <20240604092850.126083-1-m.carrara@proxmox.com>
Am 04.06.24 um 11:28 schrieb Max Carrara:
>
> Max Carrara (3):
> section config: document package and its methods with POD
> section config: update code style
> section config: clean up parser logic
>
> src/PVE/SectionConfig.pm | 982 +++++++++++++++++++++++++++++++--------
> 1 file changed, 798 insertions(+), 184 deletions(-)
>
For the record, it seems like this already got applied:
https://git.proxmox.com/?p=pve-common.git;a=commit;h=6cba8d7660b62002ffdc81655b8e8668952614a9
Could you re-send the changes for v2 as follow-ups? Or v1 could also be
reverted and v2 applied?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-07-24 11:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 9:28 [pve-devel] " Max Carrara
2024-06-04 9:28 ` [pve-devel] [PATCH v1 pve-common 1/3] section config: document package and its methods with POD Max Carrara
2024-06-11 10:46 ` Fabian Grünbichler
2024-06-13 9:14 ` Max Carrara
2024-06-04 9:28 ` [pve-devel] [PATCH v1 pve-common 2/3] section config: update code style Max Carrara
2024-06-04 9:28 ` [pve-devel] [PATCH v1 pve-common 3/3] section config: clean up parser logic Max Carrara
2024-06-11 10:46 ` Fabian Grünbichler
2024-06-13 9:27 ` Max Carrara
2024-07-24 11:34 ` Fiona Ebner [this message]
2024-07-24 11:46 ` [pve-devel] applied: [PATCH v1 pve-common 0/3] Section Config: Documentation & Code Cleanup Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54106e85-064f-42db-bc5e-0f7e43495de8@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal