[pve-devel] [PATCH pve-manager 0/2] fix #1981: get next free disk id on change of bus/device

[pve-devel] [PATCH pve-manager 0/2] fix #1981: get next free disk id on change of bus/device

[Stefan Hrdlicka]

When adding a disk to an existing VM and switching between SCSI and IDE 
(or any other bus) the gui will now select the next free device id
automatically.

Stefan Hrdlicka (2):
  fix #1981: get next free disk id on change of bus/device
  cleanup: style fix

 www/manager6/form/ControllerSelector.js | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

-- 
2.30.2

[pve-devel] [PATCH pve-manager 1/2] fix #1981: get next free disk id on change of bus/device

[Stefan Hrdlicka]

Signed-off-by: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
---
 FYI: When IDE already has 4 devices and the user tries to add another one,
 the number device number isn't changed since there isn't any space
 left.

 www/manager6/form/ControllerSelector.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js
index d84c49d6..6daede95 100644
--- a/www/manager6/form/ControllerSelector.js
+++ b/www/manager6/form/ControllerSelector.js
@@ -12,7 +12,9 @@ Ext.define('PVE.form.ControllerSelector', {
 	let freeId = PVE.Utils.nextFreeDisk(controllers, me.vmconfig);
 
 	if (freeId !== undefined) {
-	    busField.setValue(freeId.controller);
+	    if (busField !== undefined) {
+		busField.setValue(freeId.controller);
+	    }
 	    deviceIDField.setValue(freeId.id);
 	}
     },
@@ -83,6 +85,7 @@ Ext.define('PVE.form.ControllerSelector', {
 				return;
 			    }
 			    let field = me.down('field[name=deviceid]');
+			    me.setToFree([value], undefined, field);
 			    field.setMaxValue(PVE.Utils.diskControllerMaxIDs[value] - 1);
 			    field.validate();
 			},
-- 
2.30.2

Re: [pve-devel] [PATCH pve-manager 1/2] fix #1981: get next free disk id on change of bus/device

[Matthias Heiserer]

On 28.09.2022 11:37, Stefan Hrdlicka wrote:
>   	if (freeId !== undefined) {
> -	    busField.setValue(freeId.controller);
> +	    if (busField !== undefined) {
> +		busField.setValue(freeId.controller);
> +	    }
nit: IMO, optional chaining (?.) would make this more readable:
     busField?.setValue(freeId.controller);

Semantically, it should be more or less the same.
>   	    deviceIDField.setValue(freeId.id);
>   	}
>       },

[pve-devel] [PATCH pve-manager 2/2] cleanup: style fix

[Stefan Hrdlicka]

Signed-off-by: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
---
 www/manager6/form/ControllerSelector.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js
index 6daede95..e6baa893 100644
--- a/www/manager6/form/ControllerSelector.js
+++ b/www/manager6/form/ControllerSelector.js
@@ -61,7 +61,7 @@ Ext.define('PVE.form.ControllerSelector', {
     },
 
     initComponent: function() {
-	var me = this;
+	let me = this;
 
 	Ext.apply(me, {
 	    fieldLabel: gettext('Bus/Device'),
-- 
2.30.2