From: Matthias Heiserer <m.heiserer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hrdlicka <s.hrdlicka@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager 1/2] fix #1981: get next free disk id on change of bus/device
Date: Wed, 28 Sep 2022 12:28:03 +0200 [thread overview]
Message-ID: <53f3b1f4-772a-f740-98c3-cf1f6e3f9564@proxmox.com> (raw)
In-Reply-To: <20220928093756.3275614-2-s.hrdlicka@proxmox.com>
On 28.09.2022 11:37, Stefan Hrdlicka wrote:
> if (freeId !== undefined) {
> - busField.setValue(freeId.controller);
> + if (busField !== undefined) {
> + busField.setValue(freeId.controller);
> + }
nit: IMO, optional chaining (?.) would make this more readable:
busField?.setValue(freeId.controller);
Semantically, it should be more or less the same.
> deviceIDField.setValue(freeId.id);
> }
> },
next prev parent reply other threads:[~2022-09-28 10:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 9:37 [pve-devel] [PATCH pve-manager 0/2] " Stefan Hrdlicka
2022-09-28 9:37 ` [pve-devel] [PATCH pve-manager 1/2] " Stefan Hrdlicka
2022-09-28 10:28 ` Matthias Heiserer [this message]
2022-09-28 9:37 ` [pve-devel] [PATCH pve-manager 2/2] cleanup: style fix Stefan Hrdlicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53f3b1f4-772a-f740-98c3-cf1f6e3f9564@proxmox.com \
--to=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hrdlicka@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.