From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Alexander Abraham <a.abraham@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve_flutter_frontend] Updated Gradle version and some build dependencies.
Date: Mon, 3 Mar 2025 10:28:39 +0100 [thread overview]
Message-ID: <539f0a81-0b72-4b2b-bbea-e767f1781ccd@proxmox.com> (raw)
In-Reply-To: <20250220143745.135908-1-a.abraham@proxmox.com>
Am 20.02.25 um 15:37 schrieb Alexander Abraham:
> The Flutter frontend of PVE was not compilable for Android
> with the versions of different tools set in the project files.
> The versions of the tools causing this problem was updated
> and the app compiles for Android.
>
> Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
> ---
> android/app/build.gradle | 10 +++++++++-
> android/gradle/wrapper/gradle-wrapper.properties | 2 +-
> android/settings.gradle | 4 ++--
> 3 files changed, 12 insertions(+), 4 deletions(-)
>
>
applied, thanks!
I fixed-up the inconsistent assignment by dropping the `=` for the
namespace property as pointed out by Shannon – I'd encourage you to
replay on such reviews on the mailing list in the future, it's more
than fine to point out that it was just an oversight, or give the
actual reason for doing it this way, if there's any.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-03-03 9:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 14:37 [pve-devel] " Alexander Abraham
2025-02-21 14:45 ` Shannon Sterz
2025-03-03 9:38 ` Alexander Abraham
2025-03-03 9:50 ` Thomas Lamprecht
2025-03-03 12:42 ` Alexander Abraham
2025-03-03 9:28 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539f0a81-0b72-4b2b-bbea-e767f1781ccd@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.abraham@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.