Re: [pve-devel] [PATCH qemu-server] fix #4372: fix vm_resume migration callback

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

> Fabian Grünbichler <f.gruenbichler@proxmox.com> hat am 29.11.2022 13:09 CET geschrieben:
> 
>  
> the fix for the recently introduced requirement of loading the VM config while
> migrating was incomplete, since the vmlist node value could already be out of
> date by the time load_config is called.
> 
> extend the fallback behaviour even further, by doing the following sequence:
> - try regular load_config (likely case, rename already fully processed)
> - if it fails, get node from vmlist, and load_config using that
> - it that fails, invalidate the PVE::Cluster cache, retry regular load_config
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>

FWIW, I managed to trigger both the fallback and the fallback to the fallback a few times now with a slightly modified test setup, and both cases (as well as the regular code path ;)) work as expected. it triggers quite rarely for me (<1% of migrations, with about a half to a third of those requiring the fallback fallback).