all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied-series: [PATCH pmg-api/pmg-gui v2 0/6] DKIM sign mails generated by PMG itself.
Date: Tue, 25 Feb 2025 21:36:15 +0100	[thread overview]
Message-ID: <5297b045-610d-420d-8b49-1eb28e2136ec@proxmox.com> (raw)
In-Reply-To: <20250225150203.455669-1-s.ivanov@proxmox.com>

Am 25.02.25 um 16:01 schrieb Stoiko Ivanov:
> supersedes:
> https://lore.proxmox.com/pmg-devel/20250225102656.413135-1-s.ivanov@proxmox.com/T/#u
> https://lore.proxmox.com/pmg-devel/20250224232451.399803-1-s.ivanov@proxmox.com/T/#t
> 
> v1->v2:
> * add pattern, and lenght restriction on from-header format (patch 1)
> * use the default setting of 'Proxmox Mail Gateway <postmaster>' everywhere
>   instead of special-casing
> * change the dkim-signing to not die when receiving an empty or domain-less
>   envelope-sender (I only tested the positive case yesterday, where signing
>   source was the header) - keep in mind that the effect was a warning in
>   the journal, which is now a info
> * add the minimal GUI-patch to the series
> 
> I kept patch 1/1 seperately, mostly due to the change being used in all
> 3 following patches (and since the commit-message as to why the change
> should not cause regression grew rather large)
> I'm fine with all 3 patches being squashed together if this seems better
> to anyone.
> 
> Thanks very much to Maximilano and Dominik for the feedback provided
> 
> pmg-api:
> Stoiko Ivanov (6):
>   config: add admin-mail-from key
>   reports: use admin-mail-from as from header
>   smtp-engine: use admin-mail-from as from header for bounces
>   ruledb: use admin-mail-from where sensible
>   dkim: signer: log info instead of die'ing when missing domain
>   reinject_local_mail: sign mails with DKIM based on header
> 
>  src/PMG/Backup.pm        |  2 +-
>  src/PMG/CLI/pmgreport.pm |  2 +-
>  src/PMG/Config.pm        |  7 +++++++
>  src/PMG/DKIMSign.pm      | 10 ++++++++--
>  src/PMG/Quarantine.pm    |  1 +
>  src/PMG/RuleDB/Notify.pm |  8 ++++----
>  src/PMG/SMTP.pm          |  7 ++++---
>  src/PMG/Utils.pm         | 15 +++++++++++++++
>  src/bin/pmg-smtp-filter  |  1 +
>  9 files changed, 42 insertions(+), 11 deletions(-)
> 
> pmg-gui:
> Stoiko Ivanov (1):
>   configuration: options: add admin-mail-from row.
> 
>  js/SystemOptions.js | 3 +++
>  1 file changed, 3 insertions(+)
> 


applied, thanks!

maybe adding some short hint/pointer in the docs might be nice here?


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


      parent reply	other threads:[~2025-02-25 20:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-25 15:01 [pmg-devel] " Stoiko Ivanov
2025-02-25 15:01 ` [pmg-devel] [PATCH pmg-api v2 1/6] config: add admin-mail-from key Stoiko Ivanov
2025-02-25 15:01 ` [pmg-devel] [PATCH pmg-api v2 2/6] reports: use admin-mail-from as from header Stoiko Ivanov
2025-02-25 15:01 ` [pmg-devel] [PATCH pmg-api v2 3/6] smtp-engine: use admin-mail-from as from header for bounces Stoiko Ivanov
2025-02-25 15:02 ` [pmg-devel] [PATCH pmg-api v2 4/6] ruledb: use admin-mail-from where sensible Stoiko Ivanov
2025-02-25 15:02 ` [pmg-devel] [PATCH pmg-api v2 5/6] dkim: signer: log info instead of die'ing when missing domain Stoiko Ivanov
2025-02-25 15:02 ` [pmg-devel] [PATCH pmg-api v2 6/6] reinject_local_mail: sign mails with DKIM based on header Stoiko Ivanov
2025-02-25 15:02 ` [pmg-devel] [PATCH pmg-gui v2 1/1] configuration: options: add admin-mail-from row Stoiko Ivanov
2025-02-25 20:36 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5297b045-610d-420d-8b49-1eb28e2136ec@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal