From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH proxmox-firewall 1/1] firewall: properly reject ipv6 traffic
Date: Mon, 13 May 2024 14:15:02 +0200 [thread overview]
Message-ID: <529164ac-e5d1-47f6-ac94-777468c9ffaa@proxmox.com> (raw)
In-Reply-To: <20240513113504.203468-1-s.hanreich@proxmox.com>
v2 available:
https://lists.proxmox.com/pipermail/pve-devel/2024-May/063839.html
On 5/13/24 13:35, Stefan Hanreich wrote:
> ICMPv6 has different message types for rejecting traffic. With ICMP we
> used host-prohibited as rejection type, which doesn't exist in ICMPv6.
> Add an additional rule for IPv6, so it uses admin-prohibited.
>
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> proxmox-firewall/resources/proxmox-firewall.nft | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/proxmox-firewall/resources/proxmox-firewall.nft b/proxmox-firewall/resources/proxmox-firewall.nft
> index f36bf3b..0a220bf 100644
> --- a/proxmox-firewall/resources/proxmox-firewall.nft
> +++ b/proxmox-firewall/resources/proxmox-firewall.nft
> @@ -75,8 +75,9 @@ table inet proxmox-firewall {
> ip saddr 224.0.0.0/4 drop
>
> meta l4proto tcp reject with tcp reset
> - meta l4proto icmp reject with icmp type port-unreachable
> + meta l4proto icmp reject with icmpx type port-unreachable
> reject with icmp type host-prohibited
> + reject with icmpv6 type admin-prohibited
> }
>
> set v4-dc/management {
> @@ -289,8 +290,9 @@ table bridge proxmox-firewall-guests {
> ip saddr 224.0.0.0/4 drop
>
> meta l4proto tcp reject with tcp reset
> - meta l4proto icmp reject with icmp type port-unreachable
> + meta l4proto icmp reject with icmpx type port-unreachable
> reject with icmp type host-prohibited
> + reject with icmpv6 type admin-prohibited
> }
>
> chain after-vm-in {
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-05-13 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 11:35 Stefan Hanreich
2024-05-13 12:15 ` Stefan Hanreich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529164ac-e5d1-47f6-ac94-777468c9ffaa@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.