[pve-devel] applied-series: [PATCH V2 pve-network 0/4] add ebgp-evpn support

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 25.11.20 10:01, Alexandre Derumier wrote:
> This add support for a new controller plugin "bgp",
> to manage specific bgp section by host.
> This is allowing ebgp
> 
> (I'll send doc soon)
> 
> Also some fixes on pending parser
> 
> Changelog V2:
> 
> - fix some bug in bgp plugin
> 
> Alexandre Derumier (4):
>   controllers: improve bgp-evpn
>   zones: evpn : add support for loopback
>   update test documentation
>   sdn: fix : pending parser
> 
>  PVE/API2/Network/SDN/Controllers.pm         |   1 +
>  PVE/API2/Network/SDN/Zones.pm               |  12 +-
>  PVE/Network/SDN.pm                          |  45 +++++-
>  PVE/Network/SDN/Controllers.pm              |  12 +-
>  PVE/Network/SDN/Controllers/BgpPlugin.pm    | 153 ++++++++++++++++++++
>  PVE/Network/SDN/Controllers/EvpnPlugin.pm   | 122 ++++++++++------
>  PVE/Network/SDN/Controllers/FaucetPlugin.pm |   4 +-
>  PVE/Network/SDN/Controllers/Makefile        |   2 +-
>  PVE/Network/SDN/Controllers/Plugin.pm       |   9 +-
>  PVE/Network/SDN/Zones.pm                    |   2 +-
>  PVE/Network/SDN/Zones/EvpnPlugin.pm         |  12 +-
>  PVE/Network/SDN/Zones/Plugin.pm             |  39 ++---
>  PVE/Network/SDN/Zones/QinQPlugin.pm         |   2 +-
>  PVE/Network/SDN/Zones/SimplePlugin.pm       |   2 +-
>  PVE/Network/SDN/Zones/VlanPlugin.pm         |   2 +-
>  PVE/Network/SDN/Zones/VxlanPlugin.pm        |   2 +-
>  test/documentation.txt                      |  14 +-
>  17 files changed, 336 insertions(+), 99 deletions(-)
>  create mode 100644 PVE/Network/SDN/Controllers/BgpPlugin.pm
> 



applied, thanks!

FYI, I tried to create a somewhat sensible perlcritic config which could be useful.

It shows a few conditionally declared variables (`my $foo = 1 if $bar`) in pve-network,
among other things:

https://pve.proxmox.com/wiki/Perl_Style_Guide#Basic_Linting_with_perlcritic

Maybe it help you (and naturally all others) to avoid a few such possible bugs.
Note, it is not a complete check, e.g., it does not cares a bout a few things
(missing variables or so).