From: Fiona Ebner <f.ebner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 2/2] pveupdate: improve cert renew log messages
Date: Wed, 22 Oct 2025 15:09:40 +0200 [thread overview]
Message-ID: <5148599e-e2e8-4d8c-8bbf-076b8abc9182@proxmox.com> (raw)
In-Reply-To: <20250909100529.415836-2-f.gruenbichler@proxmox.com>
Am 09.09.25 um 12:05 PM schrieb Fabian Grünbichler:
> by explicitly checking for already expired certificates and adapting the
> message in that case.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> bin/pveupdate | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/bin/pveupdate b/bin/pveupdate
> index 9984c9369..c5356c885 100755
> --- a/bin/pveupdate
> +++ b/bin/pveupdate
> @@ -125,7 +125,10 @@ eval {
> PVE::Tools::run_command(['systemctl', 'reload-or-restart', 'pveproxy']);
> };
>
> - if (PVE::Certificate::check_expiry($certpath, time() + 14 * 24 * 60 * 60)) {
> + if (PVE::Certificate::check_expiry($certpath)) {
> + # already expired
> + $renew->("expired, renewing...");
> + } elsif (PVE::Certificate::check_expiry($certpath, time() + 14 * 24 * 60 * 60)) {
> # expires in next 2 weeks
> $renew->("expires soon, renewing...");
> } elsif (!PVE::Certificate::check_expiry($certpath, time() + 2 * 365 * 24 * 60 * 60)) {
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-10-22 13:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 10:04 [pve-devel] [PATCH manager 1/2] fix #6779: pveupdate: renew already expired certificates Fabian Grünbichler
2025-09-09 10:04 ` [pve-devel] [PATCH manager 2/2] pveupdate: improve cert renew log messages Fabian Grünbichler
2025-10-22 13:09 ` Fiona Ebner [this message]
2025-10-22 13:09 ` [pve-devel] [PATCH manager 1/2] fix #6779: pveupdate: renew already expired certificates Fiona Ebner
2025-10-23 8:20 ` [pve-devel] applied-series: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5148599e-e2e8-4d8c-8bbf-076b8abc9182@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.