From: Fiona Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH common 3/3] upid: fix calls to decode function
Date: Wed, 1 Oct 2025 13:17:42 +0200 [thread overview]
Message-ID: <50ef5f3c-e161-4826-b2b6-f1a6209d2377@proxmox.com> (raw)
In-Reply-To: <e775865f-e021-40d9-802a-8d7d9a661306@proxmox.com>
Am 01.10.25 um 12:34 PM schrieb Thomas Lamprecht:
> Am 01.10.25 um 11:38 schrieb Fiona Ebner:
>> The decode function has a signature and always requires two arguments.
>> Otherwise, there will be errors like:
>>> Too few arguments for subroutine 'PVE::UPID::decode'
>>> (got 1; expected 2) at /usr/share/perl5/PVE/UPID.pm line 60.
>
> I replaced this with just adapting the signature to have a default
> value for $noerr defined there, which avoids having to update
> call sides; as thanks to use v5.36 we can do
>
> sub decode($upid, $noerr = 0) {
> ...
>
>
> I also added a basic test harness to finally have some coverage
> here.
Oh, good to know that that's possible too :)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-10-01 11:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 9:36 [pve-devel] [PATCH common 0/3] upid: fix calls to decode Fiona Ebner
2025-10-01 9:36 ` [pve-devel] [PATCH common 1/3] upid: order imports alphabetically Fiona Ebner
2025-10-01 10:32 ` [pve-devel] applied: " Thomas Lamprecht
2025-10-01 9:36 ` [pve-devel] [PATCH common 2/3] upid: add missing imports Fiona Ebner
2025-10-01 9:36 ` [pve-devel] [PATCH common 3/3] upid: fix calls to decode function Fiona Ebner
2025-10-01 10:34 ` Thomas Lamprecht
2025-10-01 11:17 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ef5f3c-e161-4826-b2b6-f1a6209d2377@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.