all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server v2 1/4] agent: add should_fs_freeze helper
Date: Fri, 27 Mar 2026 02:12:39 +0100	[thread overview]
Message-ID: <4fb7df53-22cd-4bd5-a586-3b8a7a3ed32c@proxmox.com> (raw)
In-Reply-To: <16fb9fa8-a0a3-4ccb-ab8c-800c23ac2334@proxmox.com>

Am 26.03.26 um 13:54 schrieb Fiona Ebner:
> I feel like we should either rename the existing guest_fs{freeze,thaw}()
> functions or this one for consistency ('fs_freeze' versus 'fsfreeze').

Agree, that would be nicer to read too besides consistency.




  reply	other threads:[~2026-03-27  1:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25 21:28 [PATCH qemu-server v2 0/4] rework fs-freeze agent property Thomas Lamprecht
2026-03-25 21:28 ` [PATCH qemu-server v2 1/4] agent: add should_fs_freeze helper Thomas Lamprecht
2026-03-26 12:55   ` Fiona Ebner
2026-03-27  1:12     ` Thomas Lamprecht [this message]
2026-03-25 21:28 ` [PATCH qemu-server v2 2/4] agent: treat freeze-fs-on-backup as alias for guest-fsfreeze Thomas Lamprecht
2026-03-26 12:55   ` Fiona Ebner
2026-03-26 23:05     ` Thomas Lamprecht
2026-03-27  8:53       ` Fiona Ebner
2026-03-25 21:28 ` [PATCH qemu-server v2 3/4] tests: cfg2cmd: add agent guest-fsfreeze config tests Thomas Lamprecht
2026-03-26 12:55   ` Fiona Ebner
2026-03-25 21:28 ` [PATCH qemu-server v2 4/4] qga: rename guest-fsfreeze to freeze-fs Thomas Lamprecht
2026-03-26  9:08   ` Maximiliano Sandoval
2026-03-26 21:46     ` Thomas Lamprecht
2026-03-26 12:55   ` Fiona Ebner
2026-03-26 23:16 ` applied: [PATCH qemu-server v2 0/4] rework fs-freeze agent property Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fb7df53-22cd-4bd5-a586-3b8a7a3ed32c@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal