From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH common v2] SectionConfig: fix handling unknown sections
Date: Wed, 16 Aug 2023 11:32:19 +0200 [thread overview]
Message-ID: <4f4d4d5f-b67b-8983-fd15-2ebac509c422@proxmox.com> (raw)
In-Reply-To: <20230816090911.3741277-1-d.csapak@proxmox.com>
Am 16.08.23 um 11:09 schrieb Dominik Csapak:
> if we're parsing an unknown section, we cannot check the schema with
> `is_array` to check if it's an array type or not, thus we have to
> handle that separately.
>
> fix this by handling data in unknown sections like an array similar to
> "cb2646c7b4974e33f4148752deec71f0d589b0f3" in proxmox-section-config.
> This way we can write unknown section out again like we parsed it.
>
> Add a regression test for an unknown field not in the schema.
>
> This fixes an issue, where calling `qm destroy ID --purge` removed much
> of the configs ob backup jobs (since there we parse an 'unknown' section
> and run into the `is_array` error)
> (Reported in the forum: https://forum.proxmox.com/threads/132091)
>
> Suggested-by: Fiona Ebner <f.ebner@proxmox.com>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
applied, thanks! As a follow-up, I added an actual array in the unknown
section to test for that too.
prev parent reply other threads:[~2023-08-16 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 9:09 [pve-devel] " Dominik Csapak
2023-08-16 9:32 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f4d4d5f-b67b-8983-fd15-2ebac509c422@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.