From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
pdm-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox{-backup,-mail-forward} 0/5] forward mails through notification worker; PDM compatibility
Date: Thu, 7 May 2026 01:21:03 +0200 [thread overview]
Message-ID: <4e62efc3-ba0e-486c-ab34-22ed01eae012@proxmox.com> (raw)
In-Reply-To: <20260409132721.272178-1-l.wagner@proxmox.com>
Am 09.04.26 um 15:26 schrieb Lukas Wagner:
> Forwarding through the worker has a couple of benefits:
> - We don't need to bump proxmx-mail-forwarder for changes in proxmox-notify (at
> least as soon as PVE uses a similar approach as well)
> - any notification state (history, tokens) becomes easier to reason
> about if there is only one process touching it
> - we can move the Context trait implementations from proxmox_notify to the
> actual product code again
No in-depth review, but general approach:
Acked-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Please check with someone else for rolling this out though, I probably won't get
around to it over the next days, maybe Fabian or Wolfgang got time.
prev parent reply other threads:[~2026-05-06 23:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 13:27 [PATCH proxmox{-backup,-mail-forward} 0/5] forward mails through notification worker; PDM compatibility Lukas Wagner
2026-04-09 13:27 ` [PATCH proxmox-backup 1/5] notifications: move spool directory to /var/lib/proxmox-backup/notifications/queue Lukas Wagner
2026-04-09 14:52 ` Arthur Bied-Charreton
2026-04-09 13:27 ` [PATCH proxmox-backup 2/5] pull in 'mail-forwarder' feature for proxmox-notify Lukas Wagner
2026-04-09 14:54 ` Arthur Bied-Charreton
2026-04-09 13:27 ` [PATCH proxmox-mail-forward 3/5] forward using PBS' notification worker Lukas Wagner
2026-04-09 15:03 ` Arthur Bied-Charreton
2026-04-09 13:27 ` [PATCH proxmox-mail-forward 4/5] forward mails on PDM installations as well Lukas Wagner
2026-04-09 15:06 ` Arthur Bied-Charreton
2026-04-09 13:27 ` [PATCH proxmox-mail-forward 5/5] only ever forward for one product, favoring PVE over PBS over PDM Lukas Wagner
2026-04-09 15:15 ` Arthur Bied-Charreton
2026-04-24 8:34 ` ping: [PATCH proxmox{-backup,-mail-forward} 0/5] forward mails through notification worker; PDM compatibility Lukas Wagner
2026-05-06 23:21 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e62efc3-ba0e-486c-ab34-22ed01eae012@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.