From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 66F971FF13F for ; Thu, 07 May 2026 01:21:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D33C2502A; Thu, 7 May 2026 01:21:08 +0200 (CEST) Message-ID: <4e62efc3-ba0e-486c-ab34-22ed01eae012@proxmox.com> Date: Thu, 7 May 2026 01:21:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox{-backup,-mail-forward} 0/5] forward mails through notification worker; PDM compatibility To: Lukas Wagner , pdm-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com References: <20260409132721.272178-1-l.wagner@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260409132721.272178-1-l.wagner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778109555902 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CGNS2PMPTNV4YL3AJINO23JSC7RMOZCC X-Message-ID-Hash: CGNS2PMPTNV4YL3AJINO23JSC7RMOZCC X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 09.04.26 um 15:26 schrieb Lukas Wagner: > Forwarding through the worker has a couple of benefits: > - We don't need to bump proxmx-mail-forwarder for changes in proxmox-notify (at > least as soon as PVE uses a similar approach as well) > - any notification state (history, tokens) becomes easier to reason > about if there is only one process touching it > - we can move the Context trait implementations from proxmox_notify to the > actual product code again No in-depth review, but general approach: Acked-by: Thomas Lamprecht Please check with someone else for rolling this out though, I probably won't get around to it over the next days, maybe Fabian or Wolfgang got time.