[pdm-devel] [PATCH datacenter-manager] ui: dashboard: drop s3 and removable stores from PBS datastore panel

[pdm-devel] [PATCH datacenter-manager] ui: dashboard: drop s3 and removable stores from PBS datastore panel

[Christian Ebner]

The PBS datastore panel currently mixes status information
(maintenance, usage, ...) with datastore properties (removable, s3).
Since the latter will not change, and the dashboard panels are more
intended to show current status information, drop the removable and
s3 columns. The search filters remain unaffected by this, still
allowing to filter PBS datastored by these.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 ui/src/dashboard/pbs_datastores_panel.rs | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/ui/src/dashboard/pbs_datastores_panel.rs b/ui/src/dashboard/pbs_datastores_panel.rs
index 3e148e6..a06acf7 100644
--- a/ui/src/dashboard/pbs_datastores_panel.rs
+++ b/ui/src/dashboard/pbs_datastores_panel.rs
@@ -40,8 +40,6 @@ impl From<PbsDatastoresPanel> for VNode {
 pub enum StatusRow {
     Online(u64),
     UnderMaintenance(u64),
-    Removable(u64),
-    S3Backend(u64),
     HighUsage(u64),
     Unknown(u64),
     All(u64),
@@ -75,8 +73,6 @@ impl yew::Component for PbsDatastoresPanelComponent {
         let data = vec![
             StatusRow::Online(status.online),
             StatusRow::UnderMaintenance(status.under_maintenance.unwrap_or_default()),
-            StatusRow::Removable(status.removable.unwrap_or_default()),
-            StatusRow::S3Backend(status.s3_backend.unwrap_or_default()),
             StatusRow::HighUsage(status.high_usage.unwrap_or_default()),
             StatusRow::Unknown(status.unknown.unwrap_or_default()),
             StatusRow::All(status.online + status.under_maintenance.unwrap_or_default()),
@@ -121,18 +117,6 @@ fn create_list_tile(
             "Under Maintenance",
             Some(("under-maintenance", "status")),
         ),
-        StatusRow::Removable(count) => (
-            Fa::new("plug"),
-            count,
-            "Removable",
-            Some(("removable", "property")),
-        ),
-        StatusRow::S3Backend(count) => (
-            Fa::new("cloud-upload"),
-            count,
-            "S3",
-            Some(("s3", "property")),
-        ),
         StatusRow::Unknown(count) => (
             Fa::from(Status::Unknown),
             count,
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager] ui: dashboard: drop s3 and removable stores from PBS datastore panel

[Wolfgang Bumiller]

On Wed, Oct 29, 2025 at 11:09:58AM +0100, Christian Ebner wrote:
> The PBS datastore panel currently mixes status information
> (maintenance, usage, ...) with datastore properties (removable, s3).
> Since the latter will not change, and the dashboard panels are more
> intended to show current status information, drop the removable and
> s3 columns. The search filters remain unaffected by this, still
> allowing to filter PBS datastored by these.

Is there another place where we already see this? Or is something
planned?
I'm just wondering where else this would make sense.

> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  ui/src/dashboard/pbs_datastores_panel.rs | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/ui/src/dashboard/pbs_datastores_panel.rs b/ui/src/dashboard/pbs_datastores_panel.rs
> index 3e148e6..a06acf7 100644
> --- a/ui/src/dashboard/pbs_datastores_panel.rs
> +++ b/ui/src/dashboard/pbs_datastores_panel.rs
> @@ -40,8 +40,6 @@ impl From<PbsDatastoresPanel> for VNode {
>  pub enum StatusRow {
>      Online(u64),
>      UnderMaintenance(u64),
> -    Removable(u64),
> -    S3Backend(u64),
>      HighUsage(u64),
>      Unknown(u64),
>      All(u64),
> @@ -75,8 +73,6 @@ impl yew::Component for PbsDatastoresPanelComponent {
>          let data = vec![
>              StatusRow::Online(status.online),
>              StatusRow::UnderMaintenance(status.under_maintenance.unwrap_or_default()),
> -            StatusRow::Removable(status.removable.unwrap_or_default()),
> -            StatusRow::S3Backend(status.s3_backend.unwrap_or_default()),
>              StatusRow::HighUsage(status.high_usage.unwrap_or_default()),
>              StatusRow::Unknown(status.unknown.unwrap_or_default()),
>              StatusRow::All(status.online + status.under_maintenance.unwrap_or_default()),
> @@ -121,18 +117,6 @@ fn create_list_tile(
>              "Under Maintenance",
>              Some(("under-maintenance", "status")),
>          ),
> -        StatusRow::Removable(count) => (
> -            Fa::new("plug"),
> -            count,
> -            "Removable",
> -            Some(("removable", "property")),
> -        ),
> -        StatusRow::S3Backend(count) => (
> -            Fa::new("cloud-upload"),
> -            count,
> -            "S3",
> -            Some(("s3", "property")),
> -        ),
>          StatusRow::Unknown(count) => (
>              Fa::from(Status::Unknown),
>              count,
> -- 
> 2.47.3


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager] ui: dashboard: drop s3 and removable stores from PBS datastore panel

[Christian Ebner]

On 10/29/25 3:06 PM, Wolfgang Bumiller wrote:
> On Wed, Oct 29, 2025 at 11:09:58AM +0100, Christian Ebner wrote:
>> The PBS datastore panel currently mixes status information
>> (maintenance, usage, ...) with datastore properties (removable, s3).
>> Since the latter will not change, and the dashboard panels are more
>> intended to show current status information, drop the removable and
>> s3 columns. The search filters remain unaffected by this, still
>> allowing to filter PBS datastored by these.
> 
> Is there another place where we already see this? Or is something
> planned?
> I'm just wondering where else this would make sense.

No, but could be exposed in the datastore overview tab, there it already 
shows the path, comments and maintenance mode if one is set. Might that 
be fitting?


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager] ui: dashboard: drop s3 and removable stores from PBS datastore panel

[Wolfgang Bumiller]

On Wed, Oct 29, 2025 at 03:12:27PM +0100, Christian Ebner wrote:
> On 10/29/25 3:06 PM, Wolfgang Bumiller wrote:
> > On Wed, Oct 29, 2025 at 11:09:58AM +0100, Christian Ebner wrote:
> > > The PBS datastore panel currently mixes status information
> > > (maintenance, usage, ...) with datastore properties (removable, s3).
> > > Since the latter will not change, and the dashboard panels are more
> > > intended to show current status information, drop the removable and
> > > s3 columns. The search filters remain unaffected by this, still
> > > allowing to filter PBS datastored by these.
> > 
> > Is there another place where we already see this? Or is something
> > planned?
> > I'm just wondering where else this would make sense.
> 
> No, but could be exposed in the datastore overview tab, there it already
> shows the path, comments and maintenance mode if one is set. Might that be
> fitting?

Yeah probably.
(For removable ones, though, it may even make sense for them to be
marked in the list on the left?)


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager] ui: dashboard: drop s3 and removable stores from PBS datastore panel

[Thomas Lamprecht]

Am 29.10.25 um 16:14 schrieb Wolfgang Bumiller:
> On Wed, Oct 29, 2025 at 03:12:27PM +0100, Christian Ebner wrote:
>> On 10/29/25 3:06 PM, Wolfgang Bumiller wrote:
>>> On Wed, Oct 29, 2025 at 11:09:58AM +0100, Christian Ebner wrote:
>>>> The PBS datastore panel currently mixes status information
>>>> (maintenance, usage, ...) with datastore properties (removable, s3).
>>>> Since the latter will not change, and the dashboard panels are more
>>>> intended to show current status information, drop the removable and
>>>> s3 columns. The search filters remain unaffected by this, still
>>>> allowing to filter PBS datastored by these.
>>>
>>> Is there another place where we already see this? Or is something
>>> planned?
>>> I'm just wondering where else this would make sense.
>>
>> No, but could be exposed in the datastore overview tab, there it already
>> shows the path, comments and maintenance mode if one is set. Might that be
>> fitting?
> 
> Yeah probably.
> (For removable ones, though, it may even make sense for them to be
> marked in the list on the left?)

It might be nice as dedicated card/widget that shows usage, like

type        on-disk   referenced   de-dup
filesystem  1 GB       10 GB       x10
removable   ...
s3          

Albeit stats for removable naturally would need to be used from the last time
it was plugged in (and GC ran) and for S3 it's always a bit odd w.r.t.
difference between on-PBS (indexes and such) and on-S3 storage usage, so maybe
also not the best proposal, just wanted to throw it out there.


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

[pdm-devel] applied: [PATCH datacenter-manager] ui: dashboard: drop s3 and removable stores from PBS datastore panel

[Wolfgang Bumiller]

applied, thanks

On Wed, Oct 29, 2025 at 11:09:58AM +0100, Christian Ebner wrote:
> The PBS datastore panel currently mixes status information
> (maintenance, usage, ...) with datastore properties (removable, s3).
> Since the latter will not change, and the dashboard panels are more
> intended to show current status information, drop the removable and
> s3 columns. The search filters remain unaffected by this, still
> allowing to filter PBS datastored by these.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  ui/src/dashboard/pbs_datastores_panel.rs | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/ui/src/dashboard/pbs_datastores_panel.rs b/ui/src/dashboard/pbs_datastores_panel.rs
> index 3e148e6..a06acf7 100644
> --- a/ui/src/dashboard/pbs_datastores_panel.rs
> +++ b/ui/src/dashboard/pbs_datastores_panel.rs
> @@ -40,8 +40,6 @@ impl From<PbsDatastoresPanel> for VNode {
>  pub enum StatusRow {
>      Online(u64),
>      UnderMaintenance(u64),
> -    Removable(u64),
> -    S3Backend(u64),
>      HighUsage(u64),
>      Unknown(u64),
>      All(u64),
> @@ -75,8 +73,6 @@ impl yew::Component for PbsDatastoresPanelComponent {
>          let data = vec![
>              StatusRow::Online(status.online),
>              StatusRow::UnderMaintenance(status.under_maintenance.unwrap_or_default()),
> -            StatusRow::Removable(status.removable.unwrap_or_default()),
> -            StatusRow::S3Backend(status.s3_backend.unwrap_or_default()),
>              StatusRow::HighUsage(status.high_usage.unwrap_or_default()),
>              StatusRow::Unknown(status.unknown.unwrap_or_default()),
>              StatusRow::All(status.online + status.under_maintenance.unwrap_or_default()),
> @@ -121,18 +117,6 @@ fn create_list_tile(
>              "Under Maintenance",
>              Some(("under-maintenance", "status")),
>          ),
> -        StatusRow::Removable(count) => (
> -            Fa::new("plug"),
> -            count,
> -            "Removable",
> -            Some(("removable", "property")),
> -        ),
> -        StatusRow::S3Backend(count) => (
> -            Fa::new("cloud-upload"),
> -            count,
> -            "S3",
> -            Some(("s3", "property")),
> -        ),
>          StatusRow::Unknown(count) => (
>              Fa::from(Status::Unknown),
>              count,
> -- 
> 2.47.3


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel