Re: [pve-devel] [PATCH] disk management: Add support for additional Crucial SSDs

[Dominik Csapak <d.csapak@proxmox.com>]

Hi,

sorry for the late answer and thanks for your contribution :)

first, if you want to contribute please sign the harmony cla and send it 
to us (https://pve.proxmox.com/wiki/Developer_Documentation for details)

secondly, generally we do not want to start an exhaustive list of
vendor/models, but since we already support crucial and those ssds
are their current models, it probably makes sense to include it
i would prefer though to have an anchor at the beginning, since we do it 
not ourselves for that match

iow i would rather want to use

'(crucial|^ct[35]00[bm]x)' => 202,

if you do not want to sign the cla and are ok with it, one of us
can also send the (updated) patch ourselves

kind regards
Dominik

On 10/20/20 12:53 AM, Jan-Jonas Sämann wrote:
> Crucial SSDs do not necessarily contain their vendor name in the model
> string. Hence, some of them are not recognized by get_wear_leveling_info().
> 
> This patch adds support for some common consumer-grade crucial disks,
> such the CT500MX500SSD1.
> 
> Signed-off-by: Jan-Jonas Sämann <sprinterfreak@binary-kitchen.de>
> ---
>   PVE/Diskmanage.pm | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm
> index 79aafcc..37dc3bc 100644
> --- a/PVE/Diskmanage.pm
> +++ b/PVE/Diskmanage.pm
> @@ -410,7 +410,7 @@ sub get_wear_leveling_info {
>   	'samsung' => 177,
>   	'intel' => 233,
>   	'sandisk' => 233,
> -	'crucial' => 202,
> +	'(crucial|ct[35]00[bm]x)' => 202,
>   	'default' => 233,
>       };
>   
>