Re: [pve-devel] [PATCH common v4 1/2] sysfstools: file_write: extend with logging

[Dominik Csapak <d.csapak@proxmox.com>]

On 11/11/24 11:29, Thomas Lamprecht wrote:
> Am 11.11.24 um 11:17 schrieb Dominik Csapak:
>> the actual error and path is useful to know when trying to debug or
>> figure out what did not work, so warn here if there was an error.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> changes from v3:
>> * only add the logging in this patch, not the error ignore handling
>>
>>   src/PVE/SysFSTools.pm | 12 +++++++++---
>>   1 file changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/PVE/SysFSTools.pm b/src/PVE/SysFSTools.pm
>> index 0bde6d7..772f6d6 100644
>> --- a/src/PVE/SysFSTools.pm
>> +++ b/src/PVE/SysFSTools.pm
>> @@ -211,17 +211,23 @@ sub check_iommu_support{
>>       return PVE::Tools::dir_glob_regex('/sys/class/iommu/', "[^\.].*");
>>   }
>>   
>> +# writes $buf into $filename, on success returns 1, on error returns 0 and warns
>>   sub file_write {
>>       my ($filename, $buf) = @_;
>>   
>>       my $fh = IO::File->new($filename, "w");
>>       return undef if !$fh;
>>   
>> -    my $res = defined(syswrite($fh, $buf)) ? 1 : 0;
>> -
>> +    my $res = syswrite($fh, $buf);
>>       $fh->close();
> 
> just to be sure: and the fh->close cannot alter `$!` ?
> 
> Otherwise, we probably want to assign my $sys_err = $! before the $fh->close()
> call, and maybe comment that it only is relevant if $res is not defined.
> 

no, you're right, close can set $! too...

i'll send a v5 for extracting the syserr before


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel