From: Christoph Heiss <c.heiss@proxmox.com>
To: Aaron Lauterer <a.lauterer@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH 01/12] add proxmox-installer-common crate
Date: Fri, 27 Oct 2023 12:59:09 +0200 [thread overview]
Message-ID: <4cj4mysxb3uqno45rftab4ten5rfzanym7mkl3ndyrxlgwsont@hwlcont2swvw> (raw)
In-Reply-To: <20231025160011.3617524-2-a.lauterer@proxmox.com>
The .deb fails to build with this patch applied,
`proxmox-installer-common/` must also be copied to the build directory
(see `$(BUILDIR)` target in the Makefile).
On Wed, Oct 25, 2023 at 06:00:00PM +0200, Aaron Lauterer wrote:
>
> It will be used for code shared among the different crates in the
> installer. For now between the TUI installer and the upcoming auto
> installer.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> Cargo.toml | 1 +
> proxmox-installer-common/Cargo.toml | 10 ++++++++++
> proxmox-installer-common/src/lib.rs | 0
> 3 files changed, 11 insertions(+)
> create mode 100644 proxmox-installer-common/Cargo.toml
> create mode 100644 proxmox-installer-common/src/lib.rs
>
> diff --git a/Cargo.toml b/Cargo.toml
> index fd151ba..c1bd578 100644
> --- a/Cargo.toml
> +++ b/Cargo.toml
> @@ -1,5 +1,6 @@
> [workspace]
> members = [
> + "proxmox-installer-common",
> "proxmox-tui-installer",
> ]
>
> diff --git a/proxmox-installer-common/Cargo.toml b/proxmox-installer-common/Cargo.toml
> new file mode 100644
> index 0000000..b8762e8
> --- /dev/null
> +++ b/proxmox-installer-common/Cargo.toml
> @@ -0,0 +1,10 @@
> +[package]
> +name = "proxmox-installer-common"
> +version = "0.1.0"
> +edition = "2021"
> +authors = [ "Aaron Lauterer <a.lauterer@proxmox.com>" ]
> +license = "AGPL-3"
> +exclude = [ "build", "debian" ]
> +homepage = "https://www.proxmox.com"
> +
> +[dependencies]
> diff --git a/proxmox-installer-common/src/lib.rs b/proxmox-installer-common/src/lib.rs
> new file mode 100644
> index 0000000..e69de29
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
next prev parent reply other threads:[~2023-10-27 10:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 15:59 [pve-devel] [PATCH 00/12] installer: add crate for common code Aaron Lauterer
2023-10-25 16:00 ` [pve-devel] [PATCH 01/12] add proxmox-installer-common crate Aaron Lauterer
2023-10-27 10:59 ` Christoph Heiss [this message]
2023-10-25 16:00 ` [pve-devel] [PATCH 02/12] common: copy common code from tui-installer Aaron Lauterer
2023-10-27 11:14 ` Christoph Heiss
2023-10-25 16:00 ` [pve-devel] [PATCH 03/12] common: utils: add dependency for doc test Aaron Lauterer
2023-10-25 16:00 ` [pve-devel] [PATCH 04/12] common: make InstallZfsOption public Aaron Lauterer
2023-10-25 16:00 ` [pve-devel] [PATCH 05/12] common: disk_checks: make functions public Aaron Lauterer
2023-10-25 16:00 ` [pve-devel] [PATCH 06/12] tui-installer: add dependency for new common crate Aaron Lauterer
2023-10-25 16:00 ` [pve-devel] [PATCH 07/12] tui: switch to " Aaron Lauterer
2023-10-25 16:00 ` [pve-devel] [PATCH 08/12] tui: remove now unused utils.rs Aaron Lauterer
2023-10-25 16:00 ` [pve-devel] [PATCH 09/12] common: add installer_setup method Aaron Lauterer
2023-10-25 16:00 ` [pve-devel] [PATCH 10/12] common: document " Aaron Lauterer
2023-10-25 16:00 ` [pve-devel] [PATCH 11/12] tui: use installer_setup from common cate Aaron Lauterer
2023-10-25 16:00 ` [pve-devel] [PATCH 12/12] tui: remove unused read_json function Aaron Lauterer
2023-10-27 11:06 ` Christoph Heiss
2023-10-27 11:39 ` [pve-devel] [PATCH installer] buildsys: copy over `proxmox-installer-common` crate to build directory Christoph Heiss
2023-10-27 11:41 ` [pve-devel] [PATCH 00/12] installer: add crate for common code Christoph Heiss
2023-10-30 9:45 ` Aaron Lauterer
2023-11-02 19:05 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cj4mysxb3uqno45rftab4ten5rfzanym7mkl3ndyrxlgwsont@hwlcont2swvw \
--to=c.heiss@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.