From: Lukas Wagner <l.wagner@proxmox.com>
To: Philipp Hufnagl <p.hufnagl@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 pve-manager 4/5] ui: backup: add 'notification-mode' param for one-shot backup jobs.
Date: Tue, 21 Nov 2023 13:42:08 +0100 [thread overview]
Message-ID: <4ca4b741-1d4e-4bb3-9353-15b0ad9dfe8b@proxmox.com> (raw)
In-Reply-To: <6e27a91f-2a4b-4072-87ee-f097dd175a9e@proxmox.com>
On 11/21/23 13:38, Philipp Hufnagl wrote:
>> + let notificationModeSelector = Ext.create({
>> + xtype: 'proxmoxKVComboBox',
>> + comboItems: [
>> + ['auto', gettext('Auto')],
>> + ['legacy-sendmail', gettext('Email (legacy)')],
>> + ['notification-system', gettext('Notification system')],
>> + ],
>> + fieldLabel: gettext('Notification mode'),
>> + name: 'notification-mode',
>> + value: 'auto',
>> + listeners: {
>> + change: function(field, value) {
>> + mailtoField.setDisabled(value === 'notification-system');
>> + }
>> + }
>> + });
>> +
>
> nit: you missed the commas on 52 on 53
Argh, thx. Deployed/tested it via `make install` instead via
`make deb`, I think eslint is a bit more linient there.
--
- Lukas
next prev parent reply other threads:[~2023-11-21 12:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 12:23 [pve-devel] [PATCH v3 guest-common/manager 0/5] vzdump: add 'notification-mode' parameter Lukas Wagner
2023-11-21 12:23 ` [pve-devel] [PATCH v3 pve-guest-common 1/5] vzdump: config: add 'notification-mode' param for backup jobs Lukas Wagner
2023-11-21 12:23 ` [pve-devel] [PATCH v3 pve-manager 2/5] vzdump: support 'notification-mode' parameter Lukas Wagner
2023-11-21 12:23 ` [pve-devel] [PATCH v3 pve-manager 3/5] ui: backup jobs: add 'notification-mode' selector for backup jobs Lukas Wagner
2023-11-21 12:51 ` Philipp Hufnagl
2023-11-21 12:23 ` [pve-devel] [PATCH v3 pve-manager 4/5] ui: backup: add 'notification-mode' param for one-shot " Lukas Wagner
[not found] ` <6e27a91f-2a4b-4072-87ee-f097dd175a9e@proxmox.com>
2023-11-21 12:42 ` Lukas Wagner [this message]
2023-11-21 12:23 ` [pve-devel] [PATCH v3 pve-manager 5/5] ui: backup job: change field text for 'mailnotification' field Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ca4b741-1d4e-4bb3-9353-15b0ad9dfe8b@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=p.hufnagl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.