* [pve-devel] [PATCH ha-manager] d/postinst: make deb-systemd-invoke non-fatal
@ 2024-04-11 10:10 Fabian Grünbichler
2024-04-17 14:56 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Grünbichler @ 2024-04-11 10:10 UTC (permalink / raw)
To: pve-devel
else this can break an upgrade for unrelated reasons.
this also mimics debhelper behaviour more (which we only not use here because
of lack of reload support) - restructured the snippet to be more similar with
an explicit `if` as well.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
debian/pve-ha-manager.postinst | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/debian/pve-ha-manager.postinst b/debian/pve-ha-manager.postinst
index 94ab797..5c8f0cd 100644
--- a/debian/pve-ha-manager.postinst
+++ b/debian/pve-ha-manager.postinst
@@ -5,11 +5,13 @@ set -e
#DEBHELPER#
if [ "$1" = "triggered" ]; then
- systemctl --quiet is-active pve-ha-lrm.service &&
- deb-systemd-invoke reload-or-try-restart pve-ha-lrm.service
+ if systemctl --quiet is-active pve-ha-lrm.service; then
+ deb-systemd-invoke reload-or-try-restart pve-ha-lrm.service || true
+ fi
- systemctl --quiet is-active pve-ha-crm.service &&
- deb-systemd-invoke reload-or-try-restart pve-ha-crm.service
+ if systemctl --quiet is-active pve-ha-crm.service; then
+ deb-systemd-invoke reload-or-try-restart pve-ha-crm.service || true
+ fi
fi
exit 0
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH ha-manager] d/postinst: make deb-systemd-invoke non-fatal
2024-04-11 10:10 [pve-devel] [PATCH ha-manager] d/postinst: make deb-systemd-invoke non-fatal Fabian Grünbichler
@ 2024-04-17 14:56 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-04-17 14:56 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Grünbichler
Am 11/04/2024 um 12:10 schrieb Fabian Grünbichler:
> else this can break an upgrade for unrelated reasons.
>
> this also mimics debhelper behaviour more (which we only not use here because
> of lack of reload support) - restructured the snippet to be more similar with
> an explicit `if` as well.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> debian/pve-ha-manager.postinst | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-17 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-11 10:10 [pve-devel] [PATCH ha-manager] d/postinst: make deb-systemd-invoke non-fatal Fabian Grünbichler
2024-04-17 14:56 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.