From: Robert Obkircher <r.obkircher@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [PATCH container 1/3] setup: add no-op check_systemd_nesting for unmanaged CTs
Date: Thu, 5 Feb 2026 11:12:31 +0100 [thread overview]
Message-ID: <4c042b86-b809-4575-a6d7-bedbc2ca6422@proxmox.com> (raw)
In-Reply-To: <20260204091740.102914-2-d.kral@proxmox.com>
On 2/4/26 10:16, Daniel Kral wrote:
> Otherwise the container will fail to start, create and clone, because
> the plugin's check_systemd_nesting is only defined in the Base module
> but not the Unmanaged module and is called in the pre_start_hook,
> post_clone_hook, and post_create_hook.
>
> Reported in the Proxmox Forum [0].
>
> [0] https://forum.proxmox.com/threads/180258/
>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> src/PVE/LXC/Setup/Unmanaged.pm | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/LXC/Setup/Unmanaged.pm b/src/PVE/LXC/Setup/Unmanaged.pm
> index d76921e..aa26c1c 100644
> --- a/src/PVE/LXC/Setup/Unmanaged.pm
> +++ b/src/PVE/LXC/Setup/Unmanaged.pm
> @@ -51,7 +51,13 @@ sub unified_cgroupv2_support {
>
> sub get_ct_init_path {
> my ($self) = @_;
> - return '/sbin/init'; # only passed to unified_cgroupv2_support for now
> + # only passed to check_systemd_nesting and unified_cgroupv2_support for now
> + return '/sbin/init';
> +}
> +
> +sub check_systemd_nesting {
> + my ($self, $conf, $init) = @_;
> + return;
> }
Applying this patch fixed the startup problem. I tested this by
changing the ostype of a Debian container to unmanaged.
The only thing I've noticed is that the method is also missing from
Plugin.pm.
>
> sub ssh_host_key_types_to_generate {
next prev parent reply other threads:[~2026-02-05 10:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 9:17 [PATCH-SERIES container 0/3] add missing no-op methods " Daniel Kral
2026-02-04 9:17 ` [PATCH container 1/3] setup: add no-op check_systemd_nesting " Daniel Kral
2026-02-04 9:35 ` Daniel Kral
2026-02-05 10:12 ` Robert Obkircher [this message]
2026-02-05 10:46 ` Daniel Kral
2026-02-04 9:17 ` [PATCH container 2/3] setup: add no-op detect_architecture " Daniel Kral
2026-02-04 9:17 ` [PATCH container 3/3] setup: make the architecture fall back to amd64 for empty strings Daniel Kral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c042b86-b809-4575-a6d7-bedbc2ca6422@proxmox.com \
--to=r.obkircher@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.