all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH common/manager v2] adapt PVE::Tools::sendmail to match rust-implementation and use it for apt update notifications
@ 2020-09-03 12:09 Stoiko Ivanov
  2020-09-03 12:09 ` [pve-devel] [PATCH common v2 1/2] sendmail-helper: only send multipart if necessary Stoiko Ivanov
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Stoiko Ivanov @ 2020-09-03 12:09 UTC (permalink / raw)
  To: pve-devel

v1->v2:
* dropped the moving of the email regex for reuse in the sendmail helper:
  we use local usernames (mostly 'root') quite extensively in our code-base and
  our users probably do so as well (for backup notifications)
* replaced the direct invocation of /usr/sbin/sendmail by a call to the helper
  in pve-manager/PVE/API2/APT.pm
* adapted the sendmail-helper to allow for an empty display name in the from
  header, since the apt update notification mail got sent without one.

The second patch in pve-common can be squashed into the first one, if
preferred.

original cover-letter for v1:
The 2 patches adapt PVE::Tools::sendmail to closely match the recently merged
implementation in our rust repository - see [0].

I moved the email regex from JSONSchema to Tools to reuse it for the sendmail
function (and eliminate one of the few email-address regexes in our codebase).

I did not add a dependency on libtimedate-perl (where Date::Format is), since
we already use  Date::Parse in PVE::Certificate, without explicit dependency,
and it gets pulled in via libwww-perl -> libhttp-date-perl -> libtimedate-perl.

Glad to send an update for the dependency of course.

[0] https://lists.proxmox.com/pipermail/pbs-devel/2020-August/000423.html

Stoiko Ivanov (2):
  move email regex from JSONSchema to Tools
  sendmail-helper: only send multipart if necessary

 src/PVE/JSONSchema.pm |  4 ++--
 src/PVE/Tools.pm      | 49 +++++++++++++++++++++++++++++--------------
 2 files changed, 35 insertions(+), 18 deletions(-)

pve-common:
Stoiko Ivanov (2):
  sendmail-helper: only send multipart if necessary
  sendmail helper: allow empty display name in from

 src/PVE/Tools.pm | 43 +++++++++++++++++++++++++++++--------------
 1 file changed, 29 insertions(+), 14 deletions(-)

pve-manager:
Stoiko Ivanov (1):
  use PVE::Tools::sendmail for update notifications

 PVE/API2/APT.pm | 19 ++++---------------
 1 file changed, 4 insertions(+), 15 deletions(-)

-- 
2.20.1





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-09-07  8:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03 12:09 [pve-devel] [PATCH common/manager v2] adapt PVE::Tools::sendmail to match rust-implementation and use it for apt update notifications Stoiko Ivanov
2020-09-03 12:09 ` [pve-devel] [PATCH common v2 1/2] sendmail-helper: only send multipart if necessary Stoiko Ivanov
2020-09-03 12:09 ` [pve-devel] [PATCH common v2 2/2] sendmail helper: allow empty display name in from Stoiko Ivanov
2020-09-03 12:09 ` [pve-devel] [PATCH manager v2 1/1] use PVE::Tools::sendmail for update notifications Stoiko Ivanov
2020-09-07  8:06 ` [pve-devel] applied-series: [PATCH common/manager v2] adapt PVE::Tools::sendmail to match rust-implementation and use it for apt " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal