[pve-devel] [PATCH container 1/2] migration: allow rbd storages for remote migration

[pve-devel] [PATCH container 1/2] migration: allow rbd storages for remote migration

[Fiona Ebner]

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

This is a follow-up for:
https://lore.proxmox.com/pve-devel/20241217154814.82121-1-f.ebner@proxmox.com/T/#m669d0a02ebf10ab54ad18f27589902ee0b2cbace

 src/PVE/LXC/Migrate.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm
index 0debb9e..e1e6cab 100644
--- a/src/PVE/LXC/Migrate.pm
+++ b/src/PVE/LXC/Migrate.pm
@@ -303,6 +303,7 @@ sub phase1 {
 	    if ($remote) {
 		push @$migratable_storages, 'cifs';
 		push @$migratable_storages, 'nfs';
+		push @$migratable_storages, 'rbd';
 	    }
 
 	    die "storage type '$scfg->{type}' not supported\n"
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH container 2/2] migration: add reminder to evaluate dropping seemingly useless check for PVE 9

[Fiona Ebner]

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/LXC/Migrate.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm
index e1e6cab..a550d70 100644
--- a/src/PVE/LXC/Migrate.pm
+++ b/src/PVE/LXC/Migrate.pm
@@ -292,6 +292,8 @@ sub phase1 {
 	    my ($sid, $volname) = PVE::Storage::parse_volume_id($volid);
 	    my $scfg =  PVE::Storage::storage_config($self->{storecfg}, $sid);
 
+	    # FIXME PVE 9 - why is this even here, can't it just be dropped completely? The storage
+	    # layer already dies if there is no valid transport format.
 	    # TODO move to storage plugin layer?
 	    my $migratable_storages = [
 		'dir',
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH container 2/2] migration: add reminder to evaluate dropping seemingly useless check for PVE 9

[Thomas Lamprecht]

Am 18.12.24 um 11:32 schrieb Fiona Ebner:
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  src/PVE/LXC/Migrate.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

applied, thanks!

The first patch was already applied by Fabian on 2024-12-19:

https://git.proxmox.com/?p=pve-container.git;a=commit;h=a257aa44969e0775f8b31ff729f7ad591bd304b9


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] applied: [PATCH container 2/2] migration: add reminder to evaluate dropping seemingly useless check for PVE 9

[Fiona Ebner]

Am 10.02.25 um 17:12 schrieb Thomas Lamprecht:
> Am 18.12.24 um 11:32 schrieb Fiona Ebner:
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>>  src/PVE/LXC/Migrate.pm | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>>
> 
> applied, thanks!
> 
> The first patch was already applied by Fabian on 2024-12-19:
> 
> https://git.proxmox.com/?p=pve-container.git;a=commit;h=a257aa44969e0775f8b31ff729f7ad591bd304b9

Fabian told me (off-list, well...) that it's still useful as an early
check and that makes sense. I guess it can be improved by querying the
transport formats for all disks early via the storage layer proper, but
the check should not be dropped completely. And IIRC, VM migration is
currently missing such an early check.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] applied: [PATCH container 2/2] migration: add reminder to evaluate dropping seemingly useless check for PVE 9

[Thomas Lamprecht]

Am 11.02.25 um 10:45 schrieb Fiona Ebner:
> Am 10.02.25 um 17:12 schrieb Thomas Lamprecht:
>> Am 18.12.24 um 11:32 schrieb Fiona Ebner:
>>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>>> ---
>>>  src/PVE/LXC/Migrate.pm | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>>
>>
>> applied, thanks!
>>
>> The first patch was already applied by Fabian on 2024-12-19:
>>
>> https://git.proxmox.com/?p=pve-container.git;a=commit;h=a257aa44969e0775f8b31ff729f7ad591bd304b9
> 
> Fabian told me (off-list, well...) that it's still useful as an early

ah great, neither an applied mail nor a mail with such an outcome stated...

> check and that makes sense. I guess it can be improved by querying the
> transport formats for all disks early via the storage layer proper, but
> the check should not be dropped completely. And IIRC, VM migration is
> currently missing such an early check.

Still thanks for the info, I now pushed a revert of this patch with some
context in the commit message.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container 1/2] migration: allow rbd storages for remote migration

[Daniel Kral]

On 12/18/24 11:32, Fiona Ebner wrote:
> [ ... ]
> --- a/src/PVE/LXC/Migrate.pm
> +++ b/src/PVE/LXC/Migrate.pm
> @@ -303,6 +303,7 @@ sub phase1 {
>   	    if ($remote) {
>   		push @$migratable_storages, 'cifs';
>   		push @$migratable_storages, 'nfs';
> +		push @$migratable_storages, 'rbd';
>   	    }
>   
>   	    die "storage type '$scfg->{type}' not supported\n"

Works as expected, without this patch the remote migration fails. When 
applied, containers stored on rbd storages are also allowed.

Tested-by: Daniel Kral <d.kral@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel