all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Filip Schauer <f.schauer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH backup v2 2/2] disks: wipe: only zero out the first 1 MiB
Date: Tue, 11 Feb 2025 19:42:18 +0100	[thread overview]
Message-ID: <4b0509f6-98e2-46e7-ad13-5e54bb13834c@proxmox.com> (raw)
In-Reply-To: <20250211162639.141541-3-f.schauer@proxmox.com>

Am 11.02.25 um 17:26 schrieb Filip Schauer:
> Reduce the number of MiB zeroed out at the start of the disk from 200 to
> 1. This should still be sufficient to remove any remaining signatures
> missed by `wipefs`, preventing potential interference with later use of
> the disk.
> 

200 MiB is a bit to specific to have no reason behind it, did you check
up on that? Maybe something can be found in PVE's git/patch history.
I have some faint remembrance that we had to increase the area we zero
out for ceph OSDs and/or for the installer.

Or do you have any references for why this should still be sufficient?


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  reply	other threads:[~2025-02-11 18:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11 16:26 [pbs-devel] [PATCH backup v2 0/2] fix #5946: disks: wipe: ensure GPT header backup is wiped Filip Schauer
2025-02-11 16:26 ` [pbs-devel] [PATCH backup v2 1/2] " Filip Schauer
2025-02-11 18:39   ` Thomas Lamprecht
2025-02-12 11:01     ` Filip Schauer
2025-02-11 16:26 ` [pbs-devel] [PATCH backup v2 2/2] disks: wipe: only zero out the first 1 MiB Filip Schauer
2025-02-11 18:42   ` Thomas Lamprecht [this message]
2025-02-12 10:24     ` Filip Schauer
2025-02-12 13:44       ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b0509f6-98e2-46e7-ad13-5e54bb13834c@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.schauer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal