From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup 2/2] ui: tape: fix restoring a single datastore
Date: Wed, 17 May 2023 11:31:02 +0200 [thread overview]
Message-ID: <4afc0a62-e588-73ce-e88a-7e9677b98d58@proxmox.com> (raw)
In-Reply-To: <20230425135956.83518-2-d.csapak@proxmox.com>
Am 25/04/2023 um 15:59 schrieb Dominik Csapak:
> if the user selected a single datastore to restore from tape on a
> media-set that includes more than one, the ui suggests (and is
> intended to) that only that datastore will be restored on the selected
> target.
>
> The logic to construct the store mapping parameter did not consider that
> case, and simply gave the target as default store, which meant all
> datastores were restored onto the target.
>
> To fix that, we have to get the source datastore from the field, and
> construct the correct parameter ("source=target").
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/tape/window/TapeRestore.js | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>
applied, thanks!
next prev parent reply other threads:[~2023-05-17 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 13:59 [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape: fix formatting Dominik Csapak
2023-04-25 13:59 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape: fix restoring a single datastore Dominik Csapak
2023-05-17 9:31 ` Thomas Lamprecht [this message]
2023-05-17 9:30 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: tape: fix formatting Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4afc0a62-e588-73ce-e88a-7e9677b98d58@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.