all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: fix not opening 'bulk action' windows
Date: Tue, 14 Mar 2023 11:43:27 +0100	[thread overview]
Message-ID: <4acbcbe8-0686-7e6d-3c1d-89989beaf6c1@proxmox.com> (raw)
In-Reply-To: <20230314102036.3340844-1-d.csapak@proxmox.com>

Am 14/03/2023 um 11:20 schrieb Dominik Csapak:
> we previously removed the 'filters' property from the store, but this
> has the effect that the filter array is only ever initialized when
> we try to access them via the specified api of extjs
> 
> so instead of adding them manually to their array, use the 'addFilter'
> method of extjs
> 
> also use 'getStore()' instead of directly accessing the store to be
> consistent with the extjs api use
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/form/VMSelector.js | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
>

applied, thanks!




      reply	other threads:[~2023-03-14 10:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 10:20 [pve-devel] " Dominik Csapak
2023-03-14 10:43 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4acbcbe8-0686-7e6d-3c1d-89989beaf6c1@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal