From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>,
Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager/proxmox v2 0/6] pbs client: fix PBS version 3 login ticket parsing compatibility
Date: Tue, 30 Sep 2025 14:34:38 +0200 [thread overview]
Message-ID: <4ac305a2-5d44-48f9-9286-48a2520e4369@proxmox.com> (raw)
In-Reply-To: <448266d6-a81c-400e-bead-a8398801d694@proxmox.com>
Am 30.09.25 um 14:19 schrieb Christian Ebner:
> On 9/30/25 1:49 PM, Wolfgang Bumiller wrote:
>> On Tue, Sep 30, 2025 at 10:02:01AM +0200, Christian Ebner wrote:
>>> This patches fix the ticket parsing when login to instances of PBS version 3
>>> or lower. For this, the current pve_compat flags for `Login` and `Client`
>>> are refactored to be an extendable enum variant instead, adding the ticket
>>> parsing backwards compatibility. In that compatibility mode, response parsing
>>> of the ticket does not interpret the presence of the `ticket-info` field as the
>>> ticket being a `http-only` ticket and fallsback to the PBS version 3 and 4
>>> compatible parsing, as the client never used `http-only` tickets.
>>
>> I thought this field was introduced only with http-only tickets, so why
>> is it not a reliable indicator and shouldn't *that* be fixed instead?
>
> I'm not so familiar with the actual code and the changes over time here, so that might as well be the case.
FYI: Shannon is back at work tomorrow and this is not really _that_
pressing, so I'd wait at least until tomorrow to hopefully get some
better rationale.
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-09-30 12:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 8:02 Christian Ebner
2025-09-30 8:02 ` [pdm-devel] [PATCH proxmox v2 1/3] proxmox-login: refactor PVE TFA compat mode Christian Ebner
2025-09-30 8:02 ` [pdm-devel] [PATCH proxmox v2 2/3] proxmox-client: adapt to new compat mode introduced for proxmox-login Christian Ebner
2025-09-30 8:02 ` [pdm-devel] [PATCH proxmox v2 3/3] proxmox-login: add compat mode to fallback to PBS3 ticket parsing Christian Ebner
2025-09-30 8:02 ` [pdm-devel] [PATCH datacenter-manager v2 1/3] server: adapt to proxmox-client compat mode changes Christian Ebner
2025-09-30 8:02 ` [pdm-devel] [PATCH datacenter-manager v2 2/3] server: pbs-client: check and fallback to PBS v3 ticket compat mode Christian Ebner
2025-09-30 8:02 ` [pdm-devel] [PATCH datacenter-manager v2 3/3] Revert "ui: add wizard: note that login currently only works for PBS 4" Christian Ebner
2025-09-30 11:49 ` [pdm-devel] [PATCH datacenter-manager/proxmox v2 0/6] pbs client: fix PBS version 3 login ticket parsing compatibility Wolfgang Bumiller
2025-09-30 12:19 ` Christian Ebner
2025-09-30 12:34 ` Thomas Lamprecht [this message]
2025-10-01 9:33 ` Shannon Sterz
2025-10-01 13:12 ` Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ac305a2-5d44-48f9-9286-48a2520e4369@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.