From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup] gui: user: fix #2898 add dialog to set password
Date: Mon, 3 Aug 2020 11:45:30 +0200 [thread overview]
Message-ID: <4a4e6d7d-28a8-fcb2-b76d-288b78ef4ad8@proxmox.com> (raw)
In-Reply-To: <44ae1142-687b-1221-113d-58e4fd745cdd@proxmox.com>
On 7/30/20 10:22 AM, Dominik Csapak wrote:
> works as intended, one nit inline
>
> other than that:
>
> Reviewed-By: Dominik Csapak <d.csapak@proxmox.com>
> Tested-By: Dominik Csapak <d.csapak@proxmox.com>
>
>> +
>> + getValues: function(dirtyOnly) {
>> + var me = this;
>> +
>> + var values = me.callParent(arguments);
>> +
>> + return values;
>> + },
>
> if we only call callParent, is it necessary to have it at all?
You are right. Forgot to strip that after copy and pasta. Will send a v2.
prev parent reply other threads:[~2020-08-03 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 8:33 Aaron Lauterer
2020-07-30 8:22 ` Dominik Csapak
2020-08-03 9:45 ` Aaron Lauterer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a4e6d7d-28a8-fcb2-b76d-288b78ef4ad8@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.